Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: find menu open keys #177

Merged
merged 1 commit into from
Dec 20, 2022
Merged

fix: find menu open keys #177

merged 1 commit into from
Dec 20, 2022

Conversation

OverTree
Copy link
Contributor

@OverTree OverTree commented Sep 15, 2022

Types of changes

  • New feature
  • Bug fix
  • Documentation change
  • Coding style change
  • Refactoring
  • Performance improvement
  • Test cases
  • Continuous integration
  • Typescript definition change
  • Breaking change

Background and context

我现在有一个三级菜单 C(A/B/C),点击我的三级菜单后,A 展开了,但是 B 并没有展开,debug了一下发现这个函数 findMenuOpenKeys 只返回了 [ A ],预期应该返回 [A, B] 。经过修改,已经达到预期。

Solution

How is the change tested?

Changelog

Changelog(CN) Changelog(EN) Related issues

Checklist:

  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others should be submitted to master branch)

Other information

@sHow8e
Copy link
Member

sHow8e commented Sep 23, 2022

@OverTree hi 感谢PR。commit麻烦遵循一下规范哈。3q

@OverTree OverTree changed the title fix: 查找展开的菜单,支持二级以及以上,之前的逻辑有问题 fix: find menu open keys Oct 11, 2022
@sHow8e sHow8e merged commit 8287e47 into arco-design:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants