Refactored Display implementation for Platform enum #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandruradovici
suggested changes
Jan 23, 2024
alexandruradovici
suggested changes
Jan 23, 2024
alexandruradovici
suggested changes
Jan 23, 2024
src/fake.rs
Outdated
| @@ -1,75 +1,681 @@ | |||
| //! Currently used for WebAssembly unknown (non-web) only | |||
src/fake.rs
Outdated
There was a problem hiding this comment.
Please explain why do we need this file?
There was a problem hiding this comment.
I am sorry, I just noticed that I somehow copied the entire code from lib.rs to fake.rs. . I'm not sure how that happened, but I'll fix it immediately.
AldaronLau
reviewed
Jan 24, 2024
|
@sebihutanu1 I'm going to close this PR, as I have decided it's functionality doesn't belong in the whoami crate. I recommend creating a separate crate for it, depending on whoami and is-terminal, if you require this functionality. If you'd like to contribute to this project in another way, feel free to send me an email at aldaronlau@gmail.com or comment in #89, and we can figure something out. Thank you for your interest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHOAMI
Key Changes:
Display Restructuring:
disp.rs, to centralize and streamline platform-specific display functions.Aesthetic Enhancements:
To enhance the utility's adaptability, a crucial implementation has been added. The program checks whether it is running in a terminal environment (using https://crates.io/crates/is-terminal) before deciding how to display the platform. If executed in a terminal, the graphical version is presented; otherwise, in scenarios like running in a pipe, the text version is displayed.