Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sdk-only sources #3484

Closed
wants to merge 4 commits into from
Closed

Conversation

leemhenson
Copy link

Description

Adds a new sdkOnly flag to the sources config, to indicate that the source should generate an SDK but not be unified alongside the other sources.

Fixes #3482

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Environment:

  • OS:
  • @graphql-mesh/...:
  • NodeJS:

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2022

⚠️ No Changeset found

Latest commit: fd3d7bb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/theguild/graphql-mesh/21qajN8KxUbvamaRxqB8cUFRWAHT
✅ Preview: https://graphql-mesh-git-fork-leemhenson-sdk-only-source-theguild.vercel.app

@ardatan
Copy link
Owner

ardatan commented Feb 18, 2022

Due to the internals of the schema stitching, we prefer to use prefix and filter combination to hide specific fields instead of Sdk-only approach. If we provide this feature, this would lead more complicated issues in the future.
But again thank you for your PR!

@leemhenson
Copy link
Author

ok, I can make that work

@leemhenson leemhenson closed this Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate SDKs for the untransformed source schemas
2 participants