-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with naming-convention in bare mode and nested Input types #4896
Conversation
🦋 Changeset detectedLatest commit: 6e52c8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Could you add a changeset with |
Done |
Hi @jamessharp , Can I ask you to run I had a look at your changes and I will be doing some testing soon; so it won't hopefully be long since we are happy to merge this. |
Ah - I think your prettier config may have changed - I've just run I'm more than happy to commit the extra , or manually undo the prettier changes in this PR, as you see fit! |
I think we can take of prettier later. So if it is good for you other than prettier @santino , we can merge it. |
a05b008
to
6e52c8a
Compare
c3c0b9e
to
696f9c7
Compare
I don't have an access to your branch so creating a new PR. |
Description
Using the naming-convention transform in "bare" mode, it doesn't correctly transform nested field argument Input types. See #4895 for details.
The code for this transform was only operating at the root level of any Inputs when considering field arguments. This fix adapts the code to fully iterate through any Inputs, including nested ones.
Fixes #4895
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Modified the bareNamingConvention spec to include this scenario
Checklist: