Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore non-method fields in Path Object Item #4934

Merged
merged 4 commits into from
Mar 31, 2023
Merged

Ignore non-method fields in Path Object Item #4934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d14359d
path object summary/desc fix
hunterpetersen Nov 22, 2022
e2875f0
Merge branch 'Urigo:master' into master
hunterpetersen Dec 12, 2022
e8b4432
Merge branch 'master' into master
ardatan Mar 31, 2023
0a75faf
fix(openapi): ignore non method objects under paths
ardatan Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/happy-melons-vanish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@omnigraph/openapi': patch
---

Ignore non object path fields
2 changes: 1 addition & 1 deletion packages/loaders/openapi/src/getJSONSchemaOptionsFromOpenAPIOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ export async function getJSONSchemaOptionsFromOpenAPIOptions(
const pathObj = oasOrSwagger.paths[relativePath];
const pathParameters = pathObj.parameters;
for (const method in pathObj) {
if (method === 'parameters' || method === 'servers') {
if (method === 'parameters' || method === 'summary' || method === 'description' || method === 'servers') {
continue;
}
const methodObj = pathObj[method as OpenAPIV2.HttpMethods] as
Expand Down
7 changes: 7 additions & 0 deletions packages/loaders/openapi/tests/fixtures/basket.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@
},
"paths": {
"/basket": {
"summary": "Get basket",
"description": "Get basket",
"servers": [
{
"url": "https://api.example.com"
}
],
"post": {
"requestBody": {
"content": {
Expand Down