Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix auto-incremented columns marked as required fields #5882

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

EmrysMyrddin
Copy link
Collaborator

@EmrysMyrddin EmrysMyrddin commented Aug 29, 2023

Description

The MySQL handler was marking auto-incremented columns as required fields in the GraphQL schema.
It's wrong since you can provide NULL or omit auto-incremented fields even if they are marked as NOT NULL.
It was also marking as required fields NOT NULL columns with defined default, which is wrong for the same reason.

Fixes #5350
Fixes #2182

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2023

⚠️ No Changeset found

Latest commit: 9a0afe6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2023

💻 Website Preview

The latest changes are available as preview in: https://5c45c1c3.graphql-mesh.pages.dev

@github-actions
Copy link
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-mesh/mysql 0.95.3-alpha-20230831153203-5d505abed npm ↗︎ unpkg ↗︎

@ardatan ardatan merged commit 8b6ccd5 into master Sep 1, 2023
13 checks passed
@ardatan ardatan deleted the fix/#5350-optional-auto-increment-fields branch September 4, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants