enable typescript strict mode #3010

n1ru4l · 2021-05-27T07:55:44Z

No description provided.

changeset-bot · 2021-05-27T07:55:46Z

⚠️ No Changeset found

Latest commit: 29ea0a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

n1ru4l · 2021-05-27T13:09:23Z

packages/delegate/src/Transformer.ts

@@ -9,11 +9,11 @@ interface Transformation {
  context: Record<string, any>;
 }

-export class Transformer {
+export class Transformer<TContext = Record<string, any>> {


Is there any benefit in passing the TContext along with the Transforms or does it make more sense to just use any for all the type signatures that complain that TContext might be wrong (e.g. in the constructor)?

I guess yes as DelegationContext holds information about the Context?

I think those who write transforms involving the context need that to be typed correctly and passed correctly to their transforms. I am not 100% on how our use of any will affect those users. :(

We could release an alpha and ask for feedback? But, this would slow down the process of actually releasing this.

But since it is just a default value and everyone could overwrite it if desired I guess it is fine to leave it like that.

packages/delegate/src/delegateToSchema.ts

ardatan · 2021-06-06T12:18:20Z

Do you think we need a changeset to make sure the changes are released?
@yaacovCR Do you have any comments for this PR?

…nature`

ardatan#3010 (comment) ardatan#3010 (comment)

ardatan#3010 (comment)

API routes generation fix docs & components update; routing fixes gitignore update fix(deps): update dependency extract-files to v11 (ardatan#3065) Co-authored-by: Renovate Bot <bot@renovateapp.com> fix(deps): update dependency tslib to ~2.3.0 (ardatan#3067) Co-authored-by: Renovate Bot <bot@renovateapp.com> fix(deps): update dependency the-guild-components to v1.3.1 (ardatan#3070) Co-authored-by: Renovate Bot <bot@renovateapp.com> fix(deps): update dependency apollo-upload-client to v16 (ardatan#3066) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update typescript-eslint monorepo to v4.27.0 (ardatan#3071) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update babel monorepo to v7.14.6 (ardatan#3072) Co-authored-by: Renovate Bot <bot@renovateapp.com> [deploy_website] Update generate-schema.md (ardatan#3074) corrected grammar fix(deps): update dependency globby to v11.0.4 (ardatan#3077) Co-authored-by: Renovate Bot <bot@renovateapp.com> fix(deps): update dependency ws to v7.5.0 (ardatan#3078) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency typescript to v4.3.3 (ardatan#3083) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency typedoc to v0.20.37 (ardatan#3082) Co-authored-by: Renovate Bot <bot@renovateapp.com> Jest Transformer for GraphQL (ardatan#1887) * Jest Transformer for GraphQL * Changeset * Align versions * Fix package.json * yarn.lock * Fix Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com> chore(deps): update dependency @types/ws to v7.4.5 (ardatan#3084) Co-authored-by: Renovate Bot <bot@renovateapp.com> Safer use of `Object.prototype.hasOwnProperty` (ardatan#3069) * Safer use of `Object.prototype.hasOwnProperty` Fixes an error I get when GraphQL JS passes a prototypeless object into the resolver ``` ReferenceError: maybeRef is not defined at eval (eval at <anonymous> (/Users/mattalexander/Projects/edge-sites-schema/tests/regression.test.js:67:7), <anonymous>:1:38) at forEach (/projectpath/tests/regression.test.js:67:7) at Array.forEach (<anonymous>) at Object.<anonymous> (/projectpath/tests/regression.test.js:65:17) ``` * changeset and test Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com> BugFix: Handle parsing endpoints when there are no mutations (ardatan#3076) * BugFix: Handle parsing endpoints when there are no mutations * changeset and test * pass tests Co-authored-by: itai <itaimain@gmail.com> Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com> chore(deps): update dependency typescript to v4.3.4 (ardatan#3086) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency typedoc to v0.21.0 (ardatan#3087) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency typedoc-plugin-markdown to v3.10.0 (ardatan#3088) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency eslint to v7.29.0 (ardatan#3089) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency graphql to v15.5.1 (ardatan#3091) Co-authored-by: Renovate Bot <bot@renovateapp.com> enable typescript strict mode (ardatan#3010) * enable noImplicitThis * enable `strictBindCallApply` * enable `strictFunctionTypes` 1: testing * enable `strictFunctionTypes` 2: utils * enable strictFunctionTypes 3: schema * enable strictFunctionTypes 4: batch-execute * enable strictFunctionTypes 5 `load` * enable strictFunctionTypes 6 `loaders/url` * enable strictFunctionTypes 7 `webpack-loader` * enable strictFunctionTypes 8 `links` * enable strictFunctionTypes 9 `delegate` and `batch-delegate` * enable `strictFunctionTypes` 10 `wrap` * enable `strictFunctionTypes` 11 `stitch` and `stitching-directive` * enable `strictFunctionTypes` final tsconfig * remove unnecessary generic params * enable `strictNullChecks` 1 `utils` * enable `strictNullChecks` 2 `schema` * enable `strictNullChecks` 3 `resolvers-composition` * enable `strictNullChecks` 4 `webpack-loader` * enable `strictNullChecks` 5 `batch-execute` * enable `strictNullChecks` 6 `graphql-tag-plug` * enable `strictNullChecks` 7 `import` * enable `strictNullChecks` 8 `loaders/url` * enable `strictNullChecks` 8 `loaders/prisma` * enable `strictNullChecks` 8 `loaders/module` * enable `strictNullChecks` 9 `loaders/github` * enable `strictNullChecks` 12 `loaders/code-file` * enable `strictNullChecks` 13 `load` * enable `strictNullChecks` 14 `delegate` * enable `strictNullChecks` 15 `batch-delegate` * interlude: move commonly used stuff to testing folder * enable `strictNullChecks` 16 `wrap` * enable `strictNullChecks` 17 `stitch` * enable `strictNullChecks` 18 `load-files` * enable `strictNullChecks` 19 `load-typedefs` * enable `strictNullChecks` 20 `merge` * enable `strictNullChecks` 21 `node-require` * enable `strictNullChecks` 22 `mock` * enable `strictNullChecks` 22 `stitching-directive` * enable `strictNullChecks` flag in tsconfig * fix: graphql-js 14 compat * fix `strictPropertyInitialization` errors * enable strictPropertyInitialization rule * strict mode!!! * enable `noPropertyAccessFromIndexSignature` * enable `noFallthroughCasesInSwitch` and `noPropertyAccessFromIndexSignature` * Add strict to new changes * fix: remove casts as upstream issue is fixed * fix: throw if we cannot identify the operation type. ardatan#3010 (comment) ardatan#3010 (comment) * fix: change wording of error ardatan#3010 (comment) * fix: make error message more clear ardatan#3010 (comment) * refactor: use null/undefined instead of falsey check * fix: assert operation from document ardatan#3010 (comment) * fix: type narrowing not working due to generics ardatan#3010 (comment) * fix: apply feedback for relocateError * Make wrapSchema generic. Fix ardatan#3064 (#1) * Fix Build Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com> Co-authored-by: Augustin Le Fèvre <augustin.public@gmail.com> Huge cleanup before major release (breaking) (ardatan#3081) * Breaking cleanup before major release * Fix TS * More chore(deps): update typescript-eslint monorepo to v4.28.0 (ardatan#3093) Co-authored-by: Renovate Bot <bot@renovateapp.com> fix(deps): update babel monorepo to v7.14.7 (ardatan#3094) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update jest monorepo to v27.0.5 (ardatan#3095) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency @vue/compiler-sfc to v3.1.2 (ardatan#3097) Co-authored-by: Renovate Bot <bot@renovateapp.com> fix build errors Huge cleanup before major release (breaking) (ardatan#3081) * Breaking cleanup before major release * Fix TS * More chore(deps): update typescript-eslint monorepo to v4.28.0 (ardatan#3093) Co-authored-by: Renovate Bot <bot@renovateapp.com> fix(deps): update babel monorepo to v7.14.7 (ardatan#3094) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update jest monorepo to v27.0.5 (ardatan#3095) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency @vue/compiler-sfc to v3.1.2 (ardatan#3097) Co-authored-by: Renovate Bot <bot@renovateapp.com> fix(deps): update dependency the-guild-components to v1.4.0 (ardatan#3098) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency @types/node to v14.17.4 (ardatan#3101) Co-authored-by: Renovate Bot <bot@renovateapp.com> Some other refactor (ardatan#3096) * Fix typing errors in tests * ReplaObject.keys/values and forEach with for..in and for..of loops * Improve Type Checking * Update CI workflow * Fix linting * Fix TS errors for v14 * More * More * Allow incremental builds * Finish * Fix Type Check * Disable sourcemaps * Fix type issues Better changelog Respect and in and more changes chore(CI): Ability to release canaries on demand Make AggregateError spec compliant reintegration docs update updated tgc version and removed Poppins import Able to release with custom tags chore(deps): update dependency typedoc-plugin-markdown to v3.10.2 (ardatan#3107) Co-authored-by: Renovate Bot <bot@renovateapp.com> Prevent TS Server to die on VSCode chore(deps): update dependency typedoc to v0.21.1 (ardatan#3108) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency graphql-tag to v2.12.5 (ardatan#3109) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency prettier to v2.3.2 (ardatan#3110) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency typedoc to v0.21.2 (ardatan#3111) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency @types/babel__traverse to v7.14.0 (ardatan#3112) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update jest monorepo to v27.0.6 (ardatan#3115) Co-authored-by: Renovate Bot <bot@renovateapp.com> Remove Subscriber and use only Executor (ardatan#3117) * Remove Subscriber and use only Executor * Fix introspectSchema * Fix tests * Cleanup fix(deps): update dependency ws to v7.5.1 (ardatan#3118) Co-authored-by: Renovate Bot <bot@renovateapp.com> enhance(url-loader): refactor Fix rawSDL issue enhance(delegate): skip validation by default and add validateRequest option to enable chore(deps): update dependency typescript to v4.3.5 (ardatan#3122) Co-authored-by: Renovate Bot <bot@renovateapp.com> fix(file-loader): location path must be normalized (ardatan#3121) chore(deps): update dependency husky to v7 (ardatan#3123) Co-authored-by: Renovate Bot <bot@renovateapp.com> feat(graphql-tag-pluck): keep locationOffset and return graphql-js Source instead of string chore(deps): update dependency @vue/compiler-sfc to v3.1.3 (ardatan#3125) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency @vue/compiler-sfc to v3.1.4 (ardatan#3126) Co-authored-by: Renovate Bot <bot@renovateapp.com> fix(deps): update dependency @types/websocket to v1.0.3 (ardatan#3129) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency @types/ws to v7.4.6 (ardatan#3128) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency eslint to v7.30.0 (ardatan#3130) Co-authored-by: Renovate Bot <bot@renovateapp.com> fix(deps): update dependency ws to v7.5.2 (ardatan#3131) Co-authored-by: Renovate Bot <bot@renovateapp.com> fix(url-loader): fix node support for EventSource feat(resolvers-composition): add support for glob patterns (ardatan#3132) * feat(resolvers-composition): add support for glob patterns * fix(resolvers-composition): add typings for micromatch * feat(resolvers-composition): add unit tests for glob patterns * chore(resolver-compositions): cleanup * feat(docs): added samples for resolver composition path matcher format * chore: added changeset * fix(docs): typo * fix(changeset): change patch to minor * Fix tests and cleanup Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com> chore(deps): pin dependency @types/micromatch to 4.0.1 (ardatan#3133) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency nock to v13.1.1 (ardatan#3134) Co-authored-by: Renovate Bot <bot@renovateapp.com> don't throw on errors that should not be relocated (ardatan#3136) refactor: internal StitchingInfo properties (ardatan#3137) to never be undefined docs update docs update after review Some fixes update tgc version

API routes generation fix docs & components update; routing fixes gitignore update fix(deps): update dependency extract-files to v11 (#3065) Co-authored-by: Renovate Bot <bot@renovateapp.com> fix(deps): update dependency tslib to ~2.3.0 (#3067) Co-authored-by: Renovate Bot <bot@renovateapp.com> fix(deps): update dependency the-guild-components to v1.3.1 (#3070) Co-authored-by: Renovate Bot <bot@renovateapp.com> fix(deps): update dependency apollo-upload-client to v16 (#3066) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update typescript-eslint monorepo to v4.27.0 (#3071) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update babel monorepo to v7.14.6 (#3072) Co-authored-by: Renovate Bot <bot@renovateapp.com> [deploy_website] Update generate-schema.md (#3074) corrected grammar fix(deps): update dependency globby to v11.0.4 (#3077) Co-authored-by: Renovate Bot <bot@renovateapp.com> fix(deps): update dependency ws to v7.5.0 (#3078) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency typescript to v4.3.3 (#3083) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency typedoc to v0.20.37 (#3082) Co-authored-by: Renovate Bot <bot@renovateapp.com> Jest Transformer for GraphQL (#1887) * Jest Transformer for GraphQL * Changeset * Align versions * Fix package.json * yarn.lock * Fix Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com> chore(deps): update dependency @types/ws to v7.4.5 (#3084) Co-authored-by: Renovate Bot <bot@renovateapp.com> Safer use of `Object.prototype.hasOwnProperty` (#3069) * Safer use of `Object.prototype.hasOwnProperty` Fixes an error I get when GraphQL JS passes a prototypeless object into the resolver ``` ReferenceError: maybeRef is not defined at eval (eval at <anonymous> (/Users/mattalexander/Projects/edge-sites-schema/tests/regression.test.js:67:7), <anonymous>:1:38) at forEach (/projectpath/tests/regression.test.js:67:7) at Array.forEach (<anonymous>) at Object.<anonymous> (/projectpath/tests/regression.test.js:65:17) ``` * changeset and test Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com> BugFix: Handle parsing endpoints when there are no mutations (#3076) * BugFix: Handle parsing endpoints when there are no mutations * changeset and test * pass tests Co-authored-by: itai <itaimain@gmail.com> Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com> chore(deps): update dependency typescript to v4.3.4 (#3086) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency typedoc to v0.21.0 (#3087) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency typedoc-plugin-markdown to v3.10.0 (#3088) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency eslint to v7.29.0 (#3089) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency graphql to v15.5.1 (#3091) Co-authored-by: Renovate Bot <bot@renovateapp.com> enable typescript strict mode (#3010) * enable noImplicitThis * enable `strictBindCallApply` * enable `strictFunctionTypes` 1: testing * enable `strictFunctionTypes` 2: utils * enable strictFunctionTypes 3: schema * enable strictFunctionTypes 4: batch-execute * enable strictFunctionTypes 5 `load` * enable strictFunctionTypes 6 `loaders/url` * enable strictFunctionTypes 7 `webpack-loader` * enable strictFunctionTypes 8 `links` * enable strictFunctionTypes 9 `delegate` and `batch-delegate` * enable `strictFunctionTypes` 10 `wrap` * enable `strictFunctionTypes` 11 `stitch` and `stitching-directive` * enable `strictFunctionTypes` final tsconfig * remove unnecessary generic params * enable `strictNullChecks` 1 `utils` * enable `strictNullChecks` 2 `schema` * enable `strictNullChecks` 3 `resolvers-composition` * enable `strictNullChecks` 4 `webpack-loader` * enable `strictNullChecks` 5 `batch-execute` * enable `strictNullChecks` 6 `graphql-tag-plug` * enable `strictNullChecks` 7 `import` * enable `strictNullChecks` 8 `loaders/url` * enable `strictNullChecks` 8 `loaders/prisma` * enable `strictNullChecks` 8 `loaders/module` * enable `strictNullChecks` 9 `loaders/github` * enable `strictNullChecks` 12 `loaders/code-file` * enable `strictNullChecks` 13 `load` * enable `strictNullChecks` 14 `delegate` * enable `strictNullChecks` 15 `batch-delegate` * interlude: move commonly used stuff to testing folder * enable `strictNullChecks` 16 `wrap` * enable `strictNullChecks` 17 `stitch` * enable `strictNullChecks` 18 `load-files` * enable `strictNullChecks` 19 `load-typedefs` * enable `strictNullChecks` 20 `merge` * enable `strictNullChecks` 21 `node-require` * enable `strictNullChecks` 22 `mock` * enable `strictNullChecks` 22 `stitching-directive` * enable `strictNullChecks` flag in tsconfig * fix: graphql-js 14 compat * fix `strictPropertyInitialization` errors * enable strictPropertyInitialization rule * strict mode!!! * enable `noPropertyAccessFromIndexSignature` * enable `noFallthroughCasesInSwitch` and `noPropertyAccessFromIndexSignature` * Add strict to new changes * fix: remove casts as upstream issue is fixed * fix: throw if we cannot identify the operation type. #3010 (comment) #3010 (comment) * fix: change wording of error #3010 (comment) * fix: make error message more clear #3010 (comment) * refactor: use null/undefined instead of falsey check * fix: assert operation from document #3010 (comment) * fix: type narrowing not working due to generics #3010 (comment) * fix: apply feedback for relocateError * Make wrapSchema generic. Fix #3064 (#1) * Fix Build Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com> Co-authored-by: Augustin Le Fèvre <augustin.public@gmail.com> Huge cleanup before major release (breaking) (#3081) * Breaking cleanup before major release * Fix TS * More chore(deps): update typescript-eslint monorepo to v4.28.0 (#3093) Co-authored-by: Renovate Bot <bot@renovateapp.com> fix(deps): update babel monorepo to v7.14.7 (#3094) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update jest monorepo to v27.0.5 (#3095) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency @vue/compiler-sfc to v3.1.2 (#3097) Co-authored-by: Renovate Bot <bot@renovateapp.com> fix build errors Huge cleanup before major release (breaking) (#3081) * Breaking cleanup before major release * Fix TS * More chore(deps): update typescript-eslint monorepo to v4.28.0 (#3093) Co-authored-by: Renovate Bot <bot@renovateapp.com> fix(deps): update babel monorepo to v7.14.7 (#3094) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update jest monorepo to v27.0.5 (#3095) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency @vue/compiler-sfc to v3.1.2 (#3097) Co-authored-by: Renovate Bot <bot@renovateapp.com> fix(deps): update dependency the-guild-components to v1.4.0 (#3098) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency @types/node to v14.17.4 (#3101) Co-authored-by: Renovate Bot <bot@renovateapp.com> Some other refactor (#3096) * Fix typing errors in tests * ReplaObject.keys/values and forEach with for..in and for..of loops * Improve Type Checking * Update CI workflow * Fix linting * Fix TS errors for v14 * More * More * Allow incremental builds * Finish * Fix Type Check * Disable sourcemaps * Fix type issues Better changelog Respect and in and more changes chore(CI): Ability to release canaries on demand Make AggregateError spec compliant reintegration docs update updated tgc version and removed Poppins import Able to release with custom tags chore(deps): update dependency typedoc-plugin-markdown to v3.10.2 (#3107) Co-authored-by: Renovate Bot <bot@renovateapp.com> Prevent TS Server to die on VSCode chore(deps): update dependency typedoc to v0.21.1 (#3108) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency graphql-tag to v2.12.5 (#3109) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency prettier to v2.3.2 (#3110) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency typedoc to v0.21.2 (#3111) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency @types/babel__traverse to v7.14.0 (#3112) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update jest monorepo to v27.0.6 (#3115) Co-authored-by: Renovate Bot <bot@renovateapp.com> Remove Subscriber and use only Executor (#3117) * Remove Subscriber and use only Executor * Fix introspectSchema * Fix tests * Cleanup fix(deps): update dependency ws to v7.5.1 (#3118) Co-authored-by: Renovate Bot <bot@renovateapp.com> enhance(url-loader): refactor Fix rawSDL issue enhance(delegate): skip validation by default and add validateRequest option to enable chore(deps): update dependency typescript to v4.3.5 (#3122) Co-authored-by: Renovate Bot <bot@renovateapp.com> fix(file-loader): location path must be normalized (#3121) chore(deps): update dependency husky to v7 (#3123) Co-authored-by: Renovate Bot <bot@renovateapp.com> feat(graphql-tag-pluck): keep locationOffset and return graphql-js Source instead of string chore(deps): update dependency @vue/compiler-sfc to v3.1.3 (#3125) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency @vue/compiler-sfc to v3.1.4 (#3126) Co-authored-by: Renovate Bot <bot@renovateapp.com> fix(deps): update dependency @types/websocket to v1.0.3 (#3129) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency @types/ws to v7.4.6 (#3128) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency eslint to v7.30.0 (#3130) Co-authored-by: Renovate Bot <bot@renovateapp.com> fix(deps): update dependency ws to v7.5.2 (#3131) Co-authored-by: Renovate Bot <bot@renovateapp.com> fix(url-loader): fix node support for EventSource feat(resolvers-composition): add support for glob patterns (#3132) * feat(resolvers-composition): add support for glob patterns * fix(resolvers-composition): add typings for micromatch * feat(resolvers-composition): add unit tests for glob patterns * chore(resolver-compositions): cleanup * feat(docs): added samples for resolver composition path matcher format * chore: added changeset * fix(docs): typo * fix(changeset): change patch to minor * Fix tests and cleanup Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com> chore(deps): pin dependency @types/micromatch to 4.0.1 (#3133) Co-authored-by: Renovate Bot <bot@renovateapp.com> chore(deps): update dependency nock to v13.1.1 (#3134) Co-authored-by: Renovate Bot <bot@renovateapp.com> don't throw on errors that should not be relocated (#3136) refactor: internal StitchingInfo properties (#3137) to never be undefined docs update docs update after review Some fixes update tgc version

n1ru4l force-pushed the typescript-strict branch 6 times, most recently from ff815a3 to c336719 Compare May 27, 2021 12:59

n1ru4l changed the title ~~enable typescript strict flags~~ enable typescript strict flags strictBindCallApply and strictFunctionTypes May 27, 2021

n1ru4l marked this pull request as ready for review May 27, 2021 13:07

n1ru4l commented May 27, 2021

View reviewed changes

packages/delegate/src/delegateToSchema.ts Show resolved Hide resolved

n1ru4l force-pushed the typescript-strict branch from 18bbba2 to 0f0b414 Compare May 27, 2021 13:32

ardatan force-pushed the master branch from e7afcc1 to 982c8f5 Compare May 27, 2021 13:34

n1ru4l force-pushed the typescript-strict branch 2 times, most recently from f2d07e5 to ed97ef2 Compare May 27, 2021 13:36

ardatan mentioned this pull request May 27, 2021

Improving the overall type safety of the entire library #2917

Closed

4 tasks

n1ru4l force-pushed the typescript-strict branch 9 times, most recently from 74b0da3 to 167325d Compare June 3, 2021 12:24

n1ru4l force-pushed the typescript-strict branch 2 times, most recently from 44854c1 to daddb6a Compare June 4, 2021 06:53

n1ru4l changed the title ~~enable typescript strict flags strictBindCallApply and strictFunctionTypes~~ enable typescript strict mode Jun 4, 2021

PabloSzx mentioned this pull request Jun 6, 2021

pnpm + ESM support with bob-esbuild #3019

Closed

n1ru4l and others added 18 commits June 21, 2021 18:25

enable strictNullChecks 22 stitching-directive

04d4ff4

enable strictNullChecks flag in tsconfig

4106e68

fix: graphql-js 14 compat

e6c9433

fix strictPropertyInitialization errors

51f13f6

enable strictPropertyInitialization rule

13edfdd

strict mode!!!

8bd511e

enable noPropertyAccessFromIndexSignature

d00ada6

enable noFallthroughCasesInSwitch and `noPropertyAccessFromIndexSig…

81ffd42

…nature`

Add strict to new changes

39be50c

fix: remove casts as upstream issue is fixed

8249e56

fix: throw if we cannot identify the operation type.

9b42a69

ardatan#3010 (comment) ardatan#3010 (comment)

fix: change wording of error

e6fd004

ardatan#3010 (comment)

fix: make error message more clear

78f7012

ardatan#3010 (comment)

refactor: use null/undefined instead of falsey check

4e6c9ae

fix: assert operation from document

1394099

ardatan#3010 (comment)

fix: type narrowing not working due to generics

5800b78

ardatan#3010 (comment)

fix: apply feedback for relocateError

3a6a64b

Make wrapSchema generic. Fix ardatan#3064 (#1)

453ceb3

ardatan force-pushed the typescript-strict branch from 321e8ca to 453ceb3 Compare June 21, 2021 15:26

Fix Build

29ea0a7

ardatan merged commit 806faae into ardatan:master Jun 21, 2021

This was referenced Jul 5, 2021

don't throw on errors that should not be relocated #3136

Merged

refactor: internal StitchingInfo properties #3137

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enable typescript strict mode #3010

enable typescript strict mode #3010

n1ru4l commented May 27, 2021

changeset-bot bot commented May 27, 2021 •

edited

Loading

n1ru4l May 27, 2021

n1ru4l May 27, 2021 •

edited

Loading

yaacovCR Jun 8, 2021

n1ru4l Jun 10, 2021

n1ru4l Jun 10, 2021

ardatan commented Jun 6, 2021

enable typescript strict mode #3010

enable typescript strict mode #3010

Conversation

n1ru4l commented May 27, 2021

changeset-bot bot commented May 27, 2021 • edited Loading

⚠️ No Changeset found

n1ru4l May 27, 2021

Choose a reason for hiding this comment

n1ru4l May 27, 2021 • edited Loading

Choose a reason for hiding this comment

yaacovCR Jun 8, 2021

Choose a reason for hiding this comment

n1ru4l Jun 10, 2021

Choose a reason for hiding this comment

n1ru4l Jun 10, 2021

Choose a reason for hiding this comment

ardatan commented Jun 6, 2021

changeset-bot bot commented May 27, 2021 •

edited

Loading

n1ru4l May 27, 2021 •

edited

Loading