Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller resolver package #4545

Closed
wants to merge 4 commits into from
Closed

Smaller resolver package #4545

wants to merge 4 commits into from

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Jun 27, 2022

New @graphql-tools/resolvers package. This package is useful for attaching resolver to the plain non executable schemas created with buildSchema of graphql-js.
Compared to addResolversToSchema, it doesn't run additional heal processes etc because it expects the schema already doesn't have any resolvers.

Hopefully this can reduce the bundle size of Yoga because we realized that schema package has a lot together with its utils dependency.

@vercel
Copy link

vercel bot commented Jun 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
graphql-tools ❌ Failed (Inspect) Jun 27, 2022 at 9:41AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2022

🦋 Changeset detected

Latest commit: 215635f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@graphql-tools/resolvers Patch
@graphql-tools/schema Patch
@graphql-tools/batch-delegate Patch
@graphql-tools/delegate Patch
graphql-tools Patch
@graphql-tools/load Patch
@graphql-tools/mock Patch
@graphql-tools/stitch Patch
@graphql-tools/stitching-directives Patch
@graphql-tools/wrap Patch
@graphql-tools/links Patch
@graphql-tools/url-loader Patch
@graphql-tools/node-require Patch
federation-benchmark Patch
@graphql-tools/prisma-loader Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 242       ✗ 0  
     data_received..................: 28 MB   2.8 MB/s
     data_sent......................: 104 kB  10 kB/s
     http_req_blocked...............: avg=5.02µs  min=2.5µs   med=3.2µs   max=190.3µs  p(90)=4.1µs   p(95)=4.4µs   
     http_req_connecting............: avg=1.09µs  min=0s      med=0s      max=132.6µs  p(90)=0s      p(95)=0s      
   ✓ http_req_duration..............: avg=77.76ms min=67.34ms med=73.84ms max=179.64ms p(90)=79.19ms p(95)=107.22ms
       { expected_response:true }...: avg=77.76ms min=67.34ms med=73.84ms max=179.64ms p(90)=79.19ms p(95)=107.22ms
     http_req_failed................: 0.00%   ✓ 0         ✗ 121
     http_req_receiving.............: avg=181.3µs min=138.4µs med=163µs   max=1.02ms   p(90)=182.4µs p(95)=194.4µs 
     http_req_sending...............: avg=79.16µs min=17.5µs  med=25.7µs  max=1.17ms   p(90)=38.7µs  p(95)=431.71µs
     http_req_tls_handshaking.......: avg=0s      min=0s      med=0s      max=0s       p(90)=0s      p(95)=0s      
     http_req_waiting...............: avg=77.5ms  min=67.12ms med=73.63ms max=179.46ms p(90)=79.02ms p(95)=106.27ms
     http_reqs......................: 121     11.995503/s
     iteration_duration.............: avg=83.33ms min=72.12ms med=79.03ms max=184.42ms p(90)=88.8ms  p(95)=111.9ms 
     iterations.....................: 121     11.995503/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

@theguild-bot
Copy link
Collaborator

theguild-bot commented Jun 27, 2022

The latest changes of this PR are available as alpha in npm (based on the declared changesets):

@graphql-tools/batch-delegate@8.2.22-alpha-d5be380f.0
@graphql-tools/delegate@8.7.13-alpha-d5be380f.0
graphql-tools@8.2.14-alpha-d5be380f.0
@graphql-tools/links@8.2.20-alpha-d5be380f.0
@graphql-tools/load@7.6.1-alpha-d5be380f.0
@graphql-tools/prisma-loader@7.1.26-alpha-d5be380f.0
@graphql-tools/url-loader@7.10.1-alpha-d5be380f.0
@graphql-tools/mock@8.6.14-alpha-d5be380f.0
@graphql-tools/node-require@6.3.16-alpha-d5be380f.0
@graphql-tools/resolvers@0.0.1-alpha-d5be380f.0
@graphql-tools/schema@8.4.1-alpha-d5be380f.0
@graphql-tools/stitch@8.6.15-alpha-d5be380f.0
@graphql-tools/stitching-directives@2.2.20-alpha-d5be380f.0
@graphql-tools/wrap@8.4.22-alpha-d5be380f.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants