Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stitched schema loses error 'extensions' when batched #5191

Merged
merged 9 commits into from
Apr 23, 2023

Conversation

darren-west
Copy link
Contributor

Description

When an error that contains no path is returned in a batched operation the extensions are lost.

I have changed it to just return the original error but we could wrap it like so.

          resultErrors.push(createGraphQLError(error.message, { ...error, originalError: error.originalError}));

Related # (4732)

I ran into this issue and found the only way I could replicate it is on non pathed batch queries.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit tested

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2023

🦋 Changeset detected

Latest commit: a64e7ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-tools/batch-execute Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@theguild-bot theguild-bot mentioned this pull request Apr 23, 2023
@ardatan
Copy link
Owner

ardatan commented Apr 23, 2023

Thanks @darren-west !

@ardatan ardatan merged commit f24f018 into ardatan:master Apr 23, 2023
@theguild-bot theguild-bot mentioned this pull request Oct 26, 2023
@theguild-bot theguild-bot mentioned this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants