Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert subscription event source stream handling #5965

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

n1ru4l
Copy link
Collaborator

@n1ru4l n1ru4l commented Mar 8, 2024

Description

This reverts the changes for the executor introduced in #5187

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose
the solution you did and what alternatives you considered, etc...

Copy link

changeset-bot bot commented Mar 8, 2024

🦋 Changeset detected

Latest commit: 96780eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-tools/executor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 8, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/executor 1.2.2-alpha-20240311092808-96780eb2f34560b0b7e04f9c03aca63603a0deea npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Mar 8, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 352       ✗ 0  
     data_received..................: 41 MB   4.1 MB/s
     data_sent......................: 151 kB  15 kB/s
     http_req_blocked...............: avg=3.89µs   min=2.13µs  med=2.58µs   max=192.27µs p(90)=3.66µs   p(95)=3.82µs  
     http_req_connecting............: avg=704ns    min=0s      med=0s       max=123.98µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=52.71ms  min=45.85ms med=49.19ms  max=133.31ms p(90)=55.93ms  p(95)=85.17ms 
       { expected_response:true }...: avg=52.71ms  min=45.85ms med=49.19ms  max=133.31ms p(90)=55.93ms  p(95)=85.17ms 
     http_req_failed................: 0.00%   ✓ 0         ✗ 176
     http_req_receiving.............: avg=135.28µs min=95.32µs med=128.53µs max=570.38µs p(90)=150.77µs p(95)=158.66µs
     http_req_sending...............: avg=25.37µs  min=19.77µs med=24.76µs  max=61.42µs  p(90)=30.17µs  p(95)=33.85µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=52.55ms  min=45.69ms med=49.04ms  max=132.99ms p(90)=55.77ms  p(95)=84.99ms 
     http_reqs......................: 176     17.578329/s
     iteration_duration.............: avg=56.86ms  min=49.37ms med=53.11ms  max=138.05ms p(90)=62.38ms  p(95)=89.01ms 
     iterations.....................: 176     17.578329/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

Copy link
Contributor

github-actions bot commented Mar 8, 2024

💻 Website Preview

The latest changes are available as preview in: https://0e2bcebd.graphql-tools.pages.dev

@n1ru4l n1ru4l marked this pull request as ready for review March 8, 2024 14:40
@ardatan ardatan merged commit 3e10da6 into master Mar 11, 2024
29 of 30 checks passed
@ardatan ardatan deleted the fix-revert-non-compliant-subscribe-source-error branch March 11, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants