Even more type improvements

[enisdenjo]

• Remove extraneous generics, they can confuse TS and mess with inference
• ServerAdapter implements requestListener too
• NodeServerAdapterContext (previously DefaultServerAdapterContext) is not the default context - it is the context only when using Node request handler. Shouldn't be used as default for context generic.

[github-actions]

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package	Version	Info
@whatwg-node/fetch	0.4.6-alpha-20220927131110-4cfdcdb	npm ↗︎ unpkg ↗︎
@whatwg-node/server	0.4.10-alpha-20220927131110-4cfdcdb	npm ↗︎ unpkg ↗︎

[ardatan]

Are we still able to keep other methods of given object in the returned object?

const app = createServerAdapter(Router());
app.get('/', req => ...);

[enisdenjo]

Ah, so that is the reason why we need the TBaseObject generic.

The thing is, with the current setup (on master), inference does not work with the context. Try this:

interface Ctx {
  some: string;
}

const handler = (_req: Request, _ctx: Ctx) => new Response();
const adapter = createServerAdapter(handler); // TS error with handler

const request = new Request('http://localhost');
await adapter(request, ctx); // TS error with request

even passing in the Ctx as generic creates problems:

- const adapter = createServerAdapter(handler);
+ const adapter = createServerAdapter<Ctx>(handler);