Skip to content

Commit

Permalink
media: aspeed: set hsync and vsync polarities to normal before starti…
Browse files Browse the repository at this point in the history
…ng mode detection

Sometimes it detects a weird resolution such as 1024x287 when the
actual resolution is 1024x768. To resolve such an issue, this
commit adds clearing for hsync and vsync polarity register bits
at the beginning of the first mode detection. This is recommended
in the datasheet.

Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Eddie James <eajames@linux.ibm.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
  • Loading branch information
jaehyoo authored and mchehab committed Oct 24, 2019
1 parent 0e78795 commit 5b3f3c4
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/media/platform/aspeed-video.c
Original file line number Diff line number Diff line change
Expand Up @@ -740,6 +740,8 @@ static void aspeed_video_get_resolution(struct aspeed_video *video)
}

set_bit(VIDEO_RES_DETECT, &video->flags);
aspeed_video_update(video, VE_CTRL,
VE_CTRL_VSYNC_POL | VE_CTRL_HSYNC_POL, 0);
aspeed_video_enable_mode_detect(video);

rc = wait_event_interruptible_timeout(video->wait,
Expand Down

0 comments on commit 5b3f3c4

Please sign in to comment.