Remove markers and performance measurement #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tlaundal
changed the title
The marker functionality was introduced to support building a tree of streams, in effect determining how different observables relate to eachother without needing to watch values pass through. This was never used to its full potential. The effect on the codebase of RxBeach and all users is quite big, as it means we need to reexport decorated versions of operators from RxJS. BREAKING CHANGE: RxBeach no longer re-exports operators from RxJS. These operators must now be imported directly from RxJS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The marker functionality was introduced to support building a tree of
streams, in effect determining how different observables relate to
eachother without needing to watch values pass through. This was never
used to its full potential. The effect on the codebase of RxBeach and
all users is quite big, as it means we need to reexport decorated
versions of operators from RxJS.
Removing this functionality reduces the size of the library and hopefully makes it more maintainable.
BREAKING CHANGE: RxBeach no longer re-exports operators from RxJS.
These operators must now be imported directly from RxJS.