Fix: Clear up artefacts after when using scrolling text. #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #27.
The following test-code was used to reproduce the problem and confirm its fix on a Arduino Uno R4 WiFi:
w/ the changes contained in this PR this is the actual output on the LED matrix:
VID_20240110_085601.mp4
Note: the reason this issue only appeary when scrolling right (
SCROLL_RIGHT
) or down (SCROLL_DOWN
) is based on the internal implementation of fonts. They are stored as a bitmap and both bottom row and right-most column are always 0, hence a auto-cleaning of artefacts takes place. In case this behaviour should change in the future with adding fonts that contain 1s in the bottom row or right-most column the appropriate artefact-cleaning implementation has already been implemented in this PR.