Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTA image delivery via HTTPS #175

Merged
merged 11 commits into from
Aug 7, 2020
Merged

OTA image delivery via HTTPS #175

merged 11 commits into from
Aug 7, 2020

Conversation

@aentinger aentinger added the type: enhancement Proposed improvement label Jul 21, 2020
@aentinger aentinger self-assigned this Jul 21, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2020

Codecov Report

Merging #175 into master will decrease coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   95.61%   95.27%   -0.35%     
==========================================
  Files          29       25       -4     
  Lines        1004      889     -115     
==========================================
- Hits          960      847     -113     
+ Misses         44       42       -2     
Impacted Files Coverage Δ
src/utility/ota/crc.cpp
src/utility/ota/crc.h

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69a4aad...e60a620. Read the comment docs.

… an OTA image should be downloaded) as well as OTA_REQ (which performs an OTA download from said URL when it's set to true
… we leave the reception immediately because there's not always data 'available()'
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Aug 5, 2020
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Aug 5, 2020
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Aug 5, 2020
@github-actions
Copy link

github-actions bot commented Aug 6, 2020

Memory usage change @ 94fe656

Board flash RAM for global variables
arduino-beta:mbed:envie_m4 💚 -136 - -64 💚 -16 - -16
arduino-beta:mbed:envie_m7 💚 -136 - -72 💚 -16 - -16
arduino:samd:mkr1000 💚 -112 - -40 💚 -16 - -16
arduino:samd:mkrgsm1400 💚 -4608 - -3008 💚 -356 - -312
arduino:samd:mkrnb1500 💚 -112 - -40 💚 -16 - -16
arduino:samd:mkrwan1300 0 - 0 0 - 0
esp8266:esp8266:huzzah 💚 -120 - -100 💚 -32 - -20
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash
examples/ArduinoIoTCloud-Advanced
RAM for global variables
examples/ArduinoIoTCloud-Basic
flash
examples/ArduinoIoTCloud-Basic
RAM for global variables
examples/utility/ArduinoIoTCloud_Travis_CI
flash
examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables
examples/utility/Provisioning
flash
examples/utility/Provisioning
RAM for global variables
arduino-beta:mbed:envie_m4 -72 -16 -136 -16 -72 -16 -64 -16
arduino-beta:mbed:envie_m7 -136 -16 -136 -16 -136 -16 -72 -16
arduino:samd:mkr1000 -112 -16 -112 -16 -112 -16 -40 -16
arduino:samd:mkrgsm1400 -3008 -312 -3120 -312 -3128 -312 -4608 -356
arduino:samd:mkrnb1500 -112 -16 -112 -16 -112 -16 -40 -16
arduino:samd:mkrwan1300 0 0 0 0 0 0
esp8266:esp8266:huzzah -120 -24 -100 -20 -120 -32
Click for full report CSV
Board,examples/ArduinoIoTCloud-Advanced<br>flash,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,examples/ArduinoIoTCloud-Basic<br>flash,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,examples/utility/Provisioning<br>flash,examples/utility/Provisioning<br>RAM for global variables
arduino-beta:mbed:envie_m4,-72,-16,-136,-16,-72,-16,-64,-16
arduino-beta:mbed:envie_m7,-136,-16,-136,-16,-136,-16,-72,-16
arduino:samd:mkr1000,-112,-16,-112,-16,-112,-16,-40,-16
arduino:samd:mkrgsm1400,-3008,-312,-3120,-312,-3128,-312,-4608,-356
arduino:samd:mkrnb1500,-112,-16,-112,-16,-112,-16,-40,-16
arduino:samd:mkrwan1300,0,0,0,0,0,0,,
esp8266:esp8266:huzzah,-120,-24,-100,-20,-120,-32,,

@arduino-libraries arduino-libraries deleted a comment from github-actions bot Aug 6, 2020
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Aug 6, 2020
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Aug 6, 2020
@aentinger aentinger marked this pull request as ready for review August 7, 2020 09:17
@github-actions
Copy link

github-actions bot commented Aug 7, 2020

Memory usage change @ e60a620

Board flash RAM for global variables
arduino-beta:mbed:envie_m4 💚 -136 - -64 💚 -16 - -16
arduino-beta:mbed:envie_m7 💚 -136 - -72 💚 -16 - -16
arduino:samd:mkr1000 💚 -112 - -40 💚 -16 - -16
arduino:samd:mkrgsm1400 💚 -4608 - -3008 💚 -356 - -312
arduino:samd:mkrnb1500 💚 -112 - -40 💚 -16 - -16
arduino:samd:mkrwan1300 0 - 0 0 - 0
arduino:samd:mkrwifi1010 💚 -3488 - -1648 💚 -316 - -312
arduino:samd:nano_33_iot 💚 -3484 - -1652 💚 -312 - -308
esp8266:esp8266:huzzah 💚 -120 - -100 💚 -32 - -20
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash
examples/ArduinoIoTCloud-Advanced
RAM for global variables
examples/ArduinoIoTCloud-Basic
flash
examples/ArduinoIoTCloud-Basic
RAM for global variables
examples/utility/ArduinoIoTCloud_Travis_CI
flash
examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables
examples/utility/Provisioning
flash
examples/utility/Provisioning
RAM for global variables
arduino-beta:mbed:envie_m4 -72 -16 -136 -16 -72 -16 -64 -16
arduino-beta:mbed:envie_m7 -136 -16 -136 -16 -136 -16 -72 -16
arduino:samd:mkr1000 -112 -16 -112 -16 -112 -16 -40 -16
arduino:samd:mkrgsm1400 -3008 -312 -3120 -312 -3128 -312 -4608 -356
arduino:samd:mkrnb1500 -112 -16 -112 -16 -112 -16 -40 -16
arduino:samd:mkrwan1300 0 0 0 0 0 0
arduino:samd:mkrwifi1010 -1648 -312 -1768 -312 -1768 -312 -3488 -316
arduino:samd:nano_33_iot -1652 -308 -1764 -308 -1764 -308 -3484 -312
esp8266:esp8266:huzzah -120 -24 -100 -20 -120 -32
Click for full report CSV
Board,examples/ArduinoIoTCloud-Advanced<br>flash,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,examples/ArduinoIoTCloud-Basic<br>flash,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,examples/utility/Provisioning<br>flash,examples/utility/Provisioning<br>RAM for global variables
arduino-beta:mbed:envie_m4,-72,-16,-136,-16,-72,-16,-64,-16
arduino-beta:mbed:envie_m7,-136,-16,-136,-16,-136,-16,-72,-16
arduino:samd:mkr1000,-112,-16,-112,-16,-112,-16,-40,-16
arduino:samd:mkrgsm1400,-3008,-312,-3120,-312,-3128,-312,-4608,-356
arduino:samd:mkrnb1500,-112,-16,-112,-16,-112,-16,-40,-16
arduino:samd:mkrwan1300,0,0,0,0,0,0,,
arduino:samd:mkrwifi1010,-1648,-312,-1768,-312,-1768,-312,-3488,-316
arduino:samd:nano_33_iot,-1652,-308,-1764,-308,-1764,-308,-3484,-312
esp8266:esp8266:huzzah,-120,-24,-100,-20,-120,-32,,

@arduino-libraries arduino-libraries deleted a comment from github-actions bot Aug 7, 2020
@aentinger aentinger merged commit 1f1934c into master Aug 7, 2020
@aentinger aentinger deleted the ota-via-https branch August 7, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants