-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Switch LPWAN off deprecated method #428
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #428 +/- ##
=======================================
Coverage 95.00% 95.00%
=======================================
Files 27 27
Lines 1221 1221
=======================================
Hits 1160 1160
Misses 61 61 ☔ View full report in Codecov by Sentry. |
Thanks for your contribution @zfields |
Memory usage change @ 6c45416
Click for full report table
Click for full report CSV
|
Hi @zfields can you add a bit a context about the need to change |
REASON: In my testing with the MKR 1310, I noticed the modem ( I think a config define is a great idea. |
Memory usage change @ 1d2034b
Click for full report table
Click for full report CSV
|
80ce5d8
to
0fc4a54
Compare
Memory usage change @ 0fc4a54
Click for full report table
Click for full report CSV
|
@pennam, I have implemented the update you suggested. |
Memory usage change @ 77fbc52
Click for full report table
Click for full report CSV
|
Memory usage change @ bf0dcbe
Click for full report table
Click for full report CSV
|
Memory usage change @ 1602206
Click for full report table
Click for full report CSV
|
Memory usage change @ 7ce8289
Click for full report table
Click for full report CSV
|
Memory usage change @ 73fd287
Click for full report table
Click for full report CSV
|
@pennam If you don't want this change, will you let me know so I can delete it and stop maintaining the branch? Or if it needs to be fixed, just let me know what you would like to see changed. |
hi @zak sorry that this PR is taking more than expected to get merged. I'll do it today :) Just wanted to give it a spin to test and understand if and how the increased retry delay is affecting the communication. btw you don't need to force push you PRs to keep them aligned to master unless there are conflicts. Thanks |
No description provided.