Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove public functions to handle thing_id and timezone #440

Merged
merged 6 commits into from
May 13, 2024
Merged

Remove public functions to handle thing_id and timezone #440

merged 6 commits into from
May 13, 2024

Conversation

pennam
Copy link
Collaborator

@pennam pennam commented Apr 8, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Apr 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.04%. Comparing base (50b512a) to head (b629c11).
Report is 8 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
+ Coverage   95.00%   95.04%   +0.04%     
==========================================
  Files          27       27              
  Lines        1221     1231      +10     
==========================================
+ Hits         1160     1170      +10     
  Misses         61       61

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arduino-libraries arduino-libraries deleted a comment from github-actions bot Apr 9, 2024
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Apr 9, 2024
@pennam pennam force-pushed the callback-remove branch from a1176c8 to b629c11 Compare April 9, 2024 12:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Memory usage change @ b629c11

Board flash % RAM for global variables %
arduino:esp32:nano_nora 💚 -392 - -36 -0.01 - -0.0 🔺 +8 - +40 0.0 - +0.01
arduino:mbed_edge:edge_control 💚 -192 - 0 -0.02 - 0.0 🔺 +8 - +40 0.0 - +0.02
arduino:mbed_giga:giga 💚 -256 - 0 -0.01 - 0.0 🔺 0 - +32 0.0 - +0.01
arduino:mbed_nano:nanorp2040connect ❔ -239 - +162 -0.0 - 0.0 🔺 0 - +40 0.0 - +0.01
arduino:mbed_nicla:nicla_vision 💚 -256 - 0 -0.01 - 0.0 🔺 0 - +32 0.0 - +0.01
arduino:mbed_opta:opta 💚 -256 - 0 -0.01 - 0.0 🔺 0 - +32 0.0 - +0.01
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 💚 -208 - 0 -0.01 - 0.0 🔺 0 - +32 0.0 - +0.01
arduino:renesas_uno:unor4wifi 💚 -208 - -32 -0.08 - -0.01 🔺 +8 - +32 +0.02 - +0.1
arduino:samd:mkr1000 💚 -248 - 0 -0.09 - 0.0 🔺 0 - +40 0.0 - +0.12
arduino:samd:mkrgsm1400 💚 -248 - 0 -0.09 - 0.0 🔺 0 - +40 0.0 - +0.12
arduino:samd:mkrnb1500 💚 -240 - 0 -0.09 - 0.0 🔺 0 - +40 0.0 - +0.12
arduino:samd:mkrwan1300 💚 -8 - 0 -0.0 - 0.0 ❔ -8 - +24 -0.02 - +0.07
arduino:samd:mkrwifi1010 ❔ -232 - +176 -0.09 - +0.07 🔺 0 - +40 0.0 - +0.12
arduino:samd:nano_33_iot ❔ -232 - +176 -0.09 - +0.07 🔺 0 - +40 0.0 - +0.12
esp32:esp32:esp32 💚 -400 - -32 -0.03 - -0.0 🔺 +8 - +32 0.0 - +0.01
esp8266:esp8266:huzzah 💚 -272 - -16 -0.03 - -0.0 🔺 +16 - +48 +0.02 - +0.06
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash		 % examples/ArduinoIoTCloud-Advanced
RAM for global variables		 % examples/ArduinoIoTCloud-Basic
flash		 % examples/ArduinoIoTCloud-Basic
RAM for global variables		 % examples/ArduinoIoTCloud-Callbacks
flash		 % examples/ArduinoIoTCloud-Callbacks
RAM for global variables		 % examples/ArduinoIoTCloud-Schedule
flash		 % examples/ArduinoIoTCloud-Schedule
RAM for global variables		 % examples/utility/ArduinoIoTCloud_Travis_CI
flash		 % examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables		 % examples/ArduinoIoTCloud-DeferredOTA
flash		 % examples/ArduinoIoTCloud-DeferredOTA
RAM for global variables		 % examples/utility/Provisioning
flash		 % examples/utility/Provisioning
RAM for global variables		 % examples/utility/SelfProvisioning
flash		 % examples/utility/SelfProvisioning
RAM for global variables		 %
arduino:esp32:nano_nora -356 -0.01 16 0.0 -84 -0.0 8 0.0 -392 -0.01 8 0.0 -372 -0.01 40 0.01 -36 -0.0 8 0.0 -360 -0.01 8 0.0
arduino:mbed_edge:edge_control -192 -0.02 16 0.01 -64 -0.01 8 0.0 -192 -0.02 8 0.0 -128 -0.01 40 0.02 0 0.0 8 0.0
arduino:mbed_giga:giga -256 -0.01 32 0.01 -128 -0.01 0 0.0 -256 -0.01 32 0.01 -256 -0.01 32 0.01 -64 -0.0 0 0.0 -256 -0.01 0 0.0 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect -209 -0.0 16 0.01 -81 -0.0 8 0.0 -239 -0.0 8 0.0 -213 -0.0 40 0.01 -47 -0.0 8 0.0 -209 -0.0 8 0.0 0 0.0 0 0.0 162 0.0 8 0.0
arduino:mbed_nicla:nicla_vision -256 -0.01 32 0.01 -64 -0.0 0 0.0 -256 -0.01 32 0.01 -192 -0.01 32 0.01 0 0.0 0 0.0 -192 -0.01 0 0.0 0 0.0 0 0.0
arduino:mbed_opta:opta -192 -0.01 32 0.01 -128 -0.01 0 0.0 -256 -0.01 0 0.0 -256 -0.01 32 0.01 -64 -0.0 0 0.0 -256 -0.01 0 0.0 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 -184 -0.01 32 0.01 -56 -0.0 0 0.0 -208 -0.01 32 0.01 -184 -0.01 32 0.01 -16 -0.0 0 0.0 0 0.0 0 0.0
arduino:renesas_uno:unor4wifi -176 -0.07 16 0.05 -48 -0.02 8 0.02 -208 -0.08 8 0.02 -192 -0.07 32 0.1 -32 -0.01 8 0.02
arduino:samd:mkr1000 -216 -0.08 16 0.05 -88 -0.03 8 0.02 -248 -0.09 8 0.02 -216 -0.08 40 0.12 -48 -0.02 8 0.02 0 0.0 0 0.0
arduino:samd:mkrgsm1400 -216 -0.08 16 0.05 -88 -0.03 8 0.02 -248 -0.09 8 0.02 -216 -0.08 40 0.12 -48 -0.02 8 0.02 0 0.0 0 0.0
arduino:samd:mkrnb1500 -216 -0.08 16 0.05 -88 -0.03 8 0.02 -240 -0.09 8 0.02 -216 -0.08 40 0.12 -48 -0.02 8 0.02 0 0.0 0 0.0
arduino:samd:mkrwan1300 0 0.0 0 0.0 0 0.0 -8 -0.02 -8 -0.0 -8 -0.02 -8 -0.0 24 0.07 0 0.0 -8 -0.02
arduino:samd:mkrwifi1010 -200 -0.08 16 0.05 -72 -0.03 8 0.02 -232 -0.09 8 0.02 -200 -0.08 40 0.12 -32 -0.01 8 0.02 -200 -0.08 8 0.02 0 0.0 0 0.0 176 0.07 8 0.02
arduino:samd:nano_33_iot -200 -0.08 16 0.05 -72 -0.03 8 0.02 -232 -0.09 8 0.02 -200 -0.08 40 0.12 -32 -0.01 8 0.02 -200 -0.08 8 0.02 0 0.0 0 0.0 176 0.07 8 0.02
esp32:esp32:esp32 -364 -0.03 16 0.0 -76 -0.01 8 0.0 -400 -0.03 8 0.0 -372 -0.03 32 0.01 -32 -0.0 8 0.0 -368 -0.03 8 0.0
esp8266:esp8266:huzzah -240 -0.02 16 0.02 -64 -0.01 16 0.02 -272 -0.03 16 0.02 -240 -0.02 48 0.06 -16 -0.0 16 0.02
Click for full report CSV 
Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/ArduinoIoTCloud-Callbacks<br>flash,%,examples/ArduinoIoTCloud-Callbacks<br>RAM for global variables,%,examples/ArduinoIoTCloud-Schedule<br>flash,%,examples/ArduinoIoTCloud-Schedule<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/ArduinoIoTCloud-DeferredOTA<br>flash,%,examples/ArduinoIoTCloud-DeferredOTA<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:esp32:nano_nora,-356,-0.01,16,0.0,-84,-0.0,8,0.0,-392,-0.01,8,0.0,-372,-0.01,40,0.01,-36,-0.0,8,0.0,-360,-0.01,8,0.0
arduino:mbed_edge:edge_control,-192,-0.02,16,0.01,-64,-0.01,8,0.0,-192,-0.02,8,0.0,-128,-0.01,40,0.02,0,0.0,8,0.0,,,,
arduino:mbed_giga:giga,-256,-0.01,32,0.01,-128,-0.01,0,0.0,-256,-0.01,32,0.01,-256,-0.01,32,0.01,-64,-0.0,0,0.0,-256,-0.01,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,-209,-0.0,16,0.01,-81,-0.0,8,0.0,-239,-0.0,8,0.0,-213,-0.0,40,0.01,-47,-0.0,8,0.0,-209,-0.0,8,0.0,0,0.0,0,0.0,162,0.0,8,0.0
arduino:mbed_nicla:nicla_vision,-256,-0.01,32,0.01,-64,-0.0,0,0.0,-256,-0.01,32,0.01,-192,-0.01,32,0.01,0,0.0,0,0.0,-192,-0.01,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_opta:opta,-192,-0.01,32,0.01,-128,-0.01,0,0.0,-256,-0.01,0,0.0,-256,-0.01,32,0.01,-64,-0.0,0,0.0,-256,-0.01,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,,,,
arduino:renesas_portenta:portenta_c33,-184,-0.01,32,0.01,-56,-0.0,0,0.0,-208,-0.01,32,0.01,-184,-0.01,32,0.01,-16,-0.0,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:renesas_uno:unor4wifi,-176,-0.07,16,0.05,-48,-0.02,8,0.02,-208,-0.08,8,0.02,-192,-0.07,32,0.1,-32,-0.01,8,0.02,,,,,,,,,,,,
arduino:samd:mkr1000,-216,-0.08,16,0.05,-88,-0.03,8,0.02,-248,-0.09,8,0.02,-216,-0.08,40,0.12,-48,-0.02,8,0.02,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,-216,-0.08,16,0.05,-88,-0.03,8,0.02,-248,-0.09,8,0.02,-216,-0.08,40,0.12,-48,-0.02,8,0.02,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,-216,-0.08,16,0.05,-88,-0.03,8,0.02,-240,-0.09,8,0.02,-216,-0.08,40,0.12,-48,-0.02,8,0.02,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,-8,-0.02,-8,-0.0,-8,-0.02,-8,-0.0,24,0.07,0,0.0,-8,-0.02,,,,,,,,,,,,
arduino:samd:mkrwifi1010,-200,-0.08,16,0.05,-72,-0.03,8,0.02,-232,-0.09,8,0.02,-200,-0.08,40,0.12,-32,-0.01,8,0.02,-200,-0.08,8,0.02,0,0.0,0,0.0,176,0.07,8,0.02
arduino:samd:nano_33_iot,-200,-0.08,16,0.05,-72,-0.03,8,0.02,-232,-0.09,8,0.02,-200,-0.08,40,0.12,-32,-0.01,8,0.02,-200,-0.08,8,0.02,0,0.0,0,0.0,176,0.07,8,0.02
esp32:esp32:esp32,-364,-0.03,16,0.0,-76,-0.01,8,0.0,-400,-0.03,8,0.0,-372,-0.03,32,0.01,-32,-0.0,8,0.0,-368,-0.03,8,0.0,,,,,,,,
esp8266:esp8266:huzzah,-240,-0.02,16,0.02,-64,-0.01,16,0.02,-272,-0.03,16,0.02,-240,-0.02,48,0.06,-16,-0.0,16,0.02,,,,,,,,,,,,

@arduino-libraries arduino-libraries deleted a comment from github-actions bot Apr 9, 2024
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Apr 9, 2024
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Apr 9, 2024
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Apr 9, 2024
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Apr 9, 2024
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Apr 9, 2024
@pennam pennam mentioned this pull request Apr 24, 2024
Closed
@pennam pennam merged commit c5a59b7 into master May 13, 2024
43 checks passed
@pennam
Copy link
Collaborator Author

pennam commented May 13, 2024 •
edited
Loading

force pushed to revert wrong merge

@pennam pennam deleted the callback-remove branch May 23, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreagilardoni andreagilardoni andreagilardoni approved these changes

@mirkokurt mirkokurt Awaiting requested review from mirkokurt

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pennam @andreagilardoni @per1234