Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move properties containers inside class implementation #442

Merged
merged 1 commit into from
May 13, 2024

Conversation

pennam
Copy link
Collaborator

@pennam pennam commented Apr 16, 2024

No description provided.

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.04%. Comparing base (87f28a3) to head (4599853).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #442   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files          27       27           
  Lines        1231     1231           
=======================================
  Hits         1170     1170           
  Misses         61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Apr 16, 2024
@pennam pennam changed the base branch from timed-attempt to master May 13, 2024 10:12
@pennam pennam force-pushed the containers-move branch from 059b318 to 4599853 Compare May 13, 2024 10:49
Copy link

Memory usage change @ 4599853

Board flash % RAM for global variables %
arduino:esp32:nano_nora 🔺 +180 - +220 +0.01 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_edge:edge_control 🔺 +80 - +144 +0.01 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_giga:giga 🔺 0 - +208 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 🔺 0 - +132 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_vision 🔺 0 - +144 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_opta:opta 🔺 0 - +208 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 🔺 0 - +128 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:renesas_uno:unor4wifi 🔺 +136 - +160 +0.05 - +0.06 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 🔺 0 - +136 0.0 - +0.05 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 🔺 0 - +128 0.0 - +0.05 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 🔺 0 - +136 0.0 - +0.05 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 🔺 0 - +40 0.0 - +0.02 💚 -16 - -8 -0.05 - -0.02
arduino:samd:mkrwifi1010 🔺 0 - +128 0.0 - +0.05 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 🔺 0 - +128 0.0 - +0.05 0 - 0 0.0 - 0.0
esp32:esp32:esp32 🔺 +180 - +232 +0.01 - +0.02 0 - 0 0.0 - 0.0
esp8266:esp8266:huzzah 🔺 +48 - +96 0.0 - +0.01 0 - 0 0.0 - 0.0
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash
% examples/ArduinoIoTCloud-Advanced
RAM for global variables
% examples/ArduinoIoTCloud-Basic
flash
% examples/ArduinoIoTCloud-Basic
RAM for global variables
% examples/ArduinoIoTCloud-Callbacks
flash
% examples/ArduinoIoTCloud-Callbacks
RAM for global variables
% examples/ArduinoIoTCloud-Schedule
flash
% examples/ArduinoIoTCloud-Schedule
RAM for global variables
% examples/utility/ArduinoIoTCloud_Travis_CI
flash
% examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables
% examples/ArduinoIoTCloud-DeferredOTA
flash
% examples/ArduinoIoTCloud-DeferredOTA
RAM for global variables
% examples/utility/Provisioning
flash
% examples/utility/Provisioning
RAM for global variables
% examples/utility/SelfProvisioning
flash
% examples/utility/SelfProvisioning
RAM for global variables
%
arduino:esp32:nano_nora 192 0.01 0 0.0 196 0.01 0 0.0 180 0.01 0 0.0 184 0.01 0 0.0 220 0.01 0 0.0 192 0.01 0 0.0
arduino:mbed_edge:edge_control 80 0.01 0 0.0 144 0.01 0 0.0 80 0.01 0 0.0 80 0.01 0 0.0 144 0.01 0 0.0
arduino:mbed_giga:giga 144 0.01 0 0.0 144 0.01 0 0.0 144 0.01 0 0.0 144 0.01 0 0.0 208 0.01 0 0.0 144 0.01 0 0.0 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect 100 0.0 0 0.0 100 0.0 0 0.0 90 0.0 0 0.0 100 0.0 0 0.0 132 0.0 0 0.0 100 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nicla:nicla_vision 144 0.01 0 0.0 144 0.01 0 0.0 144 0.01 0 0.0 144 0.01 0 0.0 144 0.01 0 0.0 144 0.01 0 0.0 0 0.0 0 0.0
arduino:mbed_opta:opta 144 0.01 0 0.0 144 0.01 0 0.0 144 0.01 0 0.0 208 0.01 0 0.0 208 0.01 0 0.0 144 0.01 0 0.0 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 104 0.0 0 0.0 104 0.0 0 0.0 88 0.0 0 0.0 104 0.0 0 0.0 128 0.01 0 0.0 0 0.0 0 0.0
arduino:renesas_uno:unor4wifi 152 0.06 0 0.0 152 0.06 0 0.0 136 0.05 0 0.0 144 0.05 0 0.0 160 0.06 0 0.0
arduino:samd:mkr1000 104 0.04 0 0.0 104 0.04 0 0.0 96 0.04 0 0.0 104 0.04 0 0.0 136 0.05 0 0.0 0 0.0 0 0.0
arduino:samd:mkrgsm1400 104 0.04 0 0.0 104 0.04 0 0.0 88 0.03 0 0.0 104 0.04 0 0.0 128 0.05 0 0.0 0 0.0 0 0.0
arduino:samd:mkrnb1500 104 0.04 0 0.0 104 0.04 0 0.0 88 0.03 0 0.0 104 0.04 0 0.0 136 0.05 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwan1300 8 0.0 -8 -0.02 8 0.0 -16 -0.05 0 0.0 -8 -0.02 0 0.0 -16 -0.05 40 0.02 -16 -0.05
arduino:samd:mkrwifi1010 104 0.04 0 0.0 104 0.04 0 0.0 96 0.04 0 0.0 104 0.04 0 0.0 128 0.05 0 0.0 104 0.04 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:nano_33_iot 104 0.04 0 0.0 104 0.04 0 0.0 96 0.04 0 0.0 104 0.04 0 0.0 128 0.05 0 0.0 104 0.04 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
esp32:esp32:esp32 188 0.01 0 0.0 196 0.01 0 0.0 180 0.01 0 0.0 200 0.02 0 0.0 232 0.02 0 0.0 192 0.01 0 0.0
esp8266:esp8266:huzzah 64 0.01 0 0.0 80 0.01 0 0.0 48 0.0 0 0.0 64 0.01 0 0.0 96 0.01 0 0.0
Click for full report CSV
Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/ArduinoIoTCloud-Callbacks<br>flash,%,examples/ArduinoIoTCloud-Callbacks<br>RAM for global variables,%,examples/ArduinoIoTCloud-Schedule<br>flash,%,examples/ArduinoIoTCloud-Schedule<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/ArduinoIoTCloud-DeferredOTA<br>flash,%,examples/ArduinoIoTCloud-DeferredOTA<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:esp32:nano_nora,192,0.01,0,0.0,196,0.01,0,0.0,180,0.01,0,0.0,184,0.01,0,0.0,220,0.01,0,0.0,192,0.01,0,0.0
arduino:mbed_edge:edge_control,80,0.01,0,0.0,144,0.01,0,0.0,80,0.01,0,0.0,80,0.01,0,0.0,144,0.01,0,0.0,,,,
arduino:mbed_giga:giga,144,0.01,0,0.0,144,0.01,0,0.0,144,0.01,0,0.0,144,0.01,0,0.0,208,0.01,0,0.0,144,0.01,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,100,0.0,0,0.0,100,0.0,0,0.0,90,0.0,0,0.0,100,0.0,0,0.0,132,0.0,0,0.0,100,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,144,0.01,0,0.0,144,0.01,0,0.0,144,0.01,0,0.0,144,0.01,0,0.0,144,0.01,0,0.0,144,0.01,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_opta:opta,144,0.01,0,0.0,144,0.01,0,0.0,144,0.01,0,0.0,208,0.01,0,0.0,208,0.01,0,0.0,144,0.01,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,,,,
arduino:renesas_portenta:portenta_c33,104,0.0,0,0.0,104,0.0,0,0.0,88,0.0,0,0.0,104,0.0,0,0.0,128,0.01,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:renesas_uno:unor4wifi,152,0.06,0,0.0,152,0.06,0,0.0,136,0.05,0,0.0,144,0.05,0,0.0,160,0.06,0,0.0,,,,,,,,,,,,
arduino:samd:mkr1000,104,0.04,0,0.0,104,0.04,0,0.0,96,0.04,0,0.0,104,0.04,0,0.0,136,0.05,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,104,0.04,0,0.0,104,0.04,0,0.0,88,0.03,0,0.0,104,0.04,0,0.0,128,0.05,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,104,0.04,0,0.0,104,0.04,0,0.0,88,0.03,0,0.0,104,0.04,0,0.0,136,0.05,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,8,0.0,-8,-0.02,8,0.0,-16,-0.05,0,0.0,-8,-0.02,0,0.0,-16,-0.05,40,0.02,-16,-0.05,,,,,,,,,,,,
arduino:samd:mkrwifi1010,104,0.04,0,0.0,104,0.04,0,0.0,96,0.04,0,0.0,104,0.04,0,0.0,128,0.05,0,0.0,104,0.04,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,104,0.04,0,0.0,104,0.04,0,0.0,96,0.04,0,0.0,104,0.04,0,0.0,128,0.05,0,0.0,104,0.04,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,188,0.01,0,0.0,196,0.01,0,0.0,180,0.01,0,0.0,200,0.02,0,0.0,232,0.02,0,0.0,192,0.01,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,64,0.01,0,0.0,80,0.01,0,0.0,48,0.0,0,0.0,64,0.01,0,0.0,96,0.01,0,0.0,,,,,,,,,,,,

@arduino-libraries arduino-libraries deleted a comment from github-actions bot May 13, 2024
@pennam pennam merged commit 1eba6a6 into master May 13, 2024
43 checks passed
@pennam pennam deleted the containers-move branch May 23, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants