-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compatibility for esp8266 core #96
Conversation
Thanks @per1234, I forced push to revert my fix and apply your github suggestion, first time discovering the feature |
examples/BarometricPressureWebServer/BarometricPressureWebServer.ino
Outdated
Show resolved
Hide resolved
from @per1234 Co-Authored-By: d-a-v <gauchard@laas.fr>
Thanks |
Please Merge this quickly! This is needed! |
@Rotzbua @cmaglie @per1234 (in reverse-order of latest commits dates) @PaulStoffregen mentions that he has no more right to commit on this repository.
|
I'm sure @PaulStoffregen had write access (I granted it some months ago). Maybe some policy enforcement? @gvarisco can you explain why he has been removed?
Yes, this library is a real burden for a number of reasons:
I can feel the pain @PaulStoffregen suffered by maintaining this library on the last months. |
Thanks for merging, |
Hardware is not the problem. I already purchased the new hardware, Wiz610io and Wiz810sio, 3 pieces of each. Time is the resource in short supply! For the last year I've been working non-stop on Teensy 4.0, and still many libs and core lib features are not yet ported. I have much urgent work to do, so I just can not work on Ethernet right now. Likewise, I purchased two Yubikey devices for 2FA. But they are still in their original packaging. Eventually I will configure them, but that is also a low priority for me. |
This pull request:
uses standard IPAddress API to get raw IP address.
About IPAddress, the proposed change is portable with current arduino API.
raw_address() would also be a another portable candidate relying on standard IPAddress.
Side note: this Ethernet library is planned to be integrated as a git submodule into esp8266 arduino core repository and replace the old one that was copied and locally patched.