Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility for esp8266 core #96

Merged
merged 3 commits into from
Nov 19, 2019
Merged

Conversation

d-a-v
Copy link
Contributor

@d-a-v d-a-v commented Apr 21, 2019

This pull request:

  • Fixes a warning in example compilation
  • Allows to use local definitions for ntohs, htons, ntohl and htonl
  • In case of esp8266 and because of changes in IPAddress to allow IPv6,
    uses standard IPAddress API to get raw IP address.

About IPAddress, the proposed change is portable with current arduino API.
raw_address() would also be a another portable candidate relying on standard IPAddress.

Side note: this Ethernet library is planned to be integrated as a git submodule into esp8266 arduino core repository and replace the old one that was copied and locally patched.

@d-a-v
Copy link
Contributor Author

d-a-v commented Apr 22, 2019

Thanks @per1234, I forced push to revert my fix and apply your github suggestion, first time discovering the feature

from @per1234

Co-Authored-By: d-a-v <gauchard@laas.fr>
@per1234 per1234 dismissed their stale review September 16, 2019 09:43

The change I requested was resolved.

@d-a-v
Copy link
Contributor Author

d-a-v commented Sep 16, 2019

Thanks

@mynameisbill2
Copy link

Please Merge this quickly! This is needed!

@d-a-v
Copy link
Contributor Author

d-a-v commented Nov 18, 2019

@Rotzbua @cmaglie @per1234 (in reverse-order of latest commits dates)

@PaulStoffregen mentions that he has no more right to commit on this repository.
There hasn't been any single commit for more than one year (with apparently some nice PRs about supporting new hardware) (and this one we wait for to be able to submodule your driver in esp8266 arduino repository).

While it is not my business to know why Paul has no more write access to this repository, I kindly ask you to inform us ... language, diplomacy, translation ... I'd like to know whether someone is designated to be in charge of it ?

@cmaglie cmaglie merged commit 75a3c37 into arduino-libraries:master Nov 19, 2019
@cmaglie
Copy link
Contributor

cmaglie commented Nov 19, 2019

@PaulStoffregen mentions that he has no more right to commit on this repository.

I'm sure @PaulStoffregen had write access (I granted it some months ago). Maybe some policy enforcement? @gvarisco can you explain why he has been removed?

There hasn't been any single commit for more than one year (with apparently some nice PRs about supporting new hardware) (and this one we wait for to be able to submodule your driver in esp8266 arduino repository).

Yes, this library is a real burden for a number of reasons:

  • every change should be carefully tested on a lot of different hardware (now we support W5100/5200/5500 on a variety of different architectures, boards and shields).
  • the PRs here are hard, because they are complex to review, we need a senior dev to do so
  • we simply don't have developers-time to spend on this library (except for basic maintenance)

I can feel the pain @PaulStoffregen suffered by maintaining this library on the last months.

@d-a-v
Copy link
Contributor Author

d-a-v commented Nov 19, 2019

Thanks for merging,
I hope the arduino foundation can buy new hardware and send them to @PaulStoffregen. With the help (time) of some students they could test the driver and approve the new changes.

@PaulStoffregen
Copy link
Contributor

Hardware is not the problem. I already purchased the new hardware, Wiz610io and Wiz810sio, 3 pieces of each.

Time is the resource in short supply! For the last year I've been working non-stop on Teensy 4.0, and still many libs and core lib features are not yet ported. I have much urgent work to do, so I just can not work on Ethernet right now.

Likewise, I purchased two Yubikey devices for 2FA. But they are still in their original packaging. Eventually I will configure them, but that is also a low priority for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants