There should be a way to check attachment status #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One problem with the MKRNB is that sometimes when the sim card inside of the MKRNB has the status of attached, which essentially means that the sim card will be attached to the MCU, this can cause connections issues, so if you accidentally attached it, you can now easily check the status
|
Marcus Peterson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
per1234
requested changes
Mar 24, 2024
Comment on lines
-1
to
+12
| // Define the repository information in these attributes | ||
| :repository-owner: arduino-libraries | ||
| :repository-name: MKRNB | ||
| :repository-owner: marcus-peterson | ||
| :repository-name: MKRNB_v2 | ||
|
|
||
| = {repository-name} Library for Arduino = | ||
| = MKRNB_v2 Library for Arduino = | ||
|
|
||
| image:https://github.com/{repository-owner}/{repository-name}/workflows/Compile%20Examples/badge.svg["Compile Examples Status", link="https://github.com/{repository-owner}/{repository-name}/actions?workflow=Compile+Examples"] | ||
| image:https://github.com/{repository-owner}/{repository-name}/workflows/Spell%20Check/badge.svg["Spell Check Status", link="https://github.com/{repository-owner}/{repository-name}/actions?workflow=Spell+Check"] | ||
| image:https://github.com/marcus-peterson/MKRNB_v2/workflows/Compile%20Examples/badge.svg["Compile Examples Status", link="https://github.com/marcus-peterson/MKRNB_v2/actions?workflow=Compile+Examples"] | ||
| image:https://github.com/marcus-peterson/MKRNB_v2/workflows/Spell%20Check/badge.svg["Spell Check Status", link="https://github.com/marcus-peterson/MKRNB_v2/actions?workflow=Spell+Check"] | ||
|
|
||
| This library enables an Arduino MKR NB 1500 board to connect to the internet over a NarrowBand IoT or LTE Cat M1 network. | ||
| This library enables an Arduino MKR NB 1500 board to connect to the internet over a NarrowBand IoT or LTE Cat M1 network. It is an extension of the original MKRNB library, designed to provide enhanced control and capabilities for commercial applications. | ||
|
|
||
| For more information about this library please visit us at | ||
| https://www.arduino.cc/en/Reference/{repository-name} | ||
| For more information about the source of this library please visit the official Arduino MKRNB documentation | ||
| https://www.arduino.cc/en/Reference/MKRNB |
There was a problem hiding this comment.
Although the changes made here would be good to make in your own "hard fork" of the library, they would be harmful to Arduino's repository if introduced by the merge of this pull request. Please revert these changes.
Note that the best workflow for pull requests from a fork is to create a dedicated branch in the fork repository in which to stage the changes made in the pull request. You submitted this pull request from the master branch of your fork and any commit you push to the master branch becomes part of the changeset of this pull request.
per1234
added
type: enhancement
|
Memory usage change @ 017c826
Click for full report table
Click for full report CSV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had so many freaking issues with the attach(), detach() stuff. I realized, there wasn't a good way to check the actual attachment status of the SIM-card. So I made this, it works.