Remove redundant and outdated library metadata file #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
library.json is PlatformIO's native library manifest file but library.properties is also supported: https://docs.platformio.org/en/latest/librarymanager/creating.html The library.json file has not been maintained. The version is outdated and it also has an incorrect `platforms` value. So the evidence makes it obvious that having two metadata files in this project has a harmful effect. Since the Arduino development software requires library.properties, the choice of keeping library.properties and removing library.json is clear.
Closed
chrisy
pushed a commit
to chrisy/NTPClient
that referenced
this pull request
Apr 16, 2022
…json Remove redundant and outdated library metadata file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
library.json is PlatformIO's native library manifest file but library.properties is also supported:
https://docs.platformio.org/en/latest/librarymanager/creating.html
The library.json file has not been maintained. The version is outdated and it also has an incorrect
platformsvalue. So the evidence makes it obvious that having two metadata files in this project has a harmful effect. Since the Arduino development software requires library.properties, the choice of keeping library.properties and removing library.json is clear.Supersedes #78