Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RobotIR library to play nice with other versions of IR-Remote #2200

Closed
wants to merge 2 commits into from

Conversation

joshuajnoble
Copy link

This leaves all the functionality of RobotIR in place but updates the underlying IRRemote library that I'm maintaining now. The AVR_ROBOT_CONTROL and AVR_ROBOT_MOTOR #defines are used to indicate that the board is the Arduino Robot and that the pin defines should be left in.

@ArduinoBot
Copy link
Contributor

Can I build this pull request?

@joshuajnoble
Copy link
Author

Yes? I mean, yes, it builds, but...:)

@ffissore
Copy link
Contributor

@joshuajnoble sorry for the comment from arduinobot. we are setting up automated build of all PRs, so that we can provide a downloadable version of the patched IDE

@joshuajnoble
Copy link
Author

Fantastic stuff, excellent idea.

@ArduinoBot
Copy link
Contributor

Can one of the admins verify this patch?

@PaoloP74
Copy link
Contributor

@ffissore
Can be integrated into 1.6.0rc1?
The IrRemote is a library used much.

@PaoloP74
Copy link
Contributor

Can you change the name of library from IrRemote to RobotIRremote?
This would avoid conflict with the original IrRemote.

@PaulStoffregen
Copy link
Sponsor Contributor

I have been working on improved header to library name matching code. It's still a work-in-progress, but already solves this problem and others. I was planning to add several more cases before submitting a pull request. But maybe it should be considered now, and more cases added later?

@ffissore
Copy link
Contributor

Closing this as it has been fixed with #2681

@ffissore ffissore closed this Mar 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants