Fix command line with relative paths

[cmaglie]

• Added test for command line with relative paths (issue --verify with relative filename does not work #5836)
• Fixed cmd line regression

This fix #5836

[matthijskooijman]

Looks good to me. Just tested this with the script that exposed this problem, that also works.

[matthijskooijman]

@cmaglie, are you also fixing the missing error handling?

[ArduinoBot]

✅ Build completed.

Please test this code using one of the following:

⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-5878-BUILD-639-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-5878-BUILD-639-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-5878-BUILD-639-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-5878-BUILD-639-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-5878-BUILD-639-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.

[cmaglie]

are you also fixing the missing error handling?

Not yet, I didn't looked the internals yet, but from looking at the code that launch the build:

      try {
          [............]
          outputFile = new Compiler(sketch).build(progress -> {}, false);
       } catch (Exception e) {
         // Error during build
         System.exit(1);
       }

it seems that an excpetion is raised also when a compile error occurs (that should not be an exception at all...) and in that case we should not print the exception/stacktrace.
I think that Compiler.build(..) needs to be refactored to not throw exceptions for build errors to properly fix this. I'll leave this change for now.

[matthijskooijman]

I think that Compiler.build(..) needs to be refactored to not throw exceptions for build errors to properly fix this.

Yeah, probably indeed. Perhaps showing just the exception message and not the stacktrace is a compromise for now? Then at least something is shown on errors, instead of just nothing when some internal exception happens?

[cmaglie]

Then at least something is shown on errors, instead of just nothing when some internal exception happens?

I'll cover this in another PR.