Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Klocwork issues in CurieEEPROM #142

Closed
bbaltz505 opened this issue Mar 8, 2016 · 2 comments
Closed

Klocwork issues in CurieEEPROM #142

bbaltz505 opened this issue Mar 8, 2016 · 2 comments
Assignees
@bbaltz505
Labels
bug
Milestone
Bellatrix

Comments

@bbaltz505
Copy link
Contributor

Klocwork found 2 issues in CurieEEPROM:

  • CurieEEPROM.cpp (line 69):
    Array 'blockdata' of size 128 may use index value(s) 128..511
int blockIndex = address/4;
blockdata[blockIndex] = data;

Same issue on:

  • CurieEEPROM.cpp (line 127):
  • CurieEEPROM.cpp (line 132):
bigdinotech added a commit to bigdinotech/corelibs-arduino101 that referenced this issue Mar 8, 2016
@bigdinotech
Fix Klockwork issues in CurieEEPROM arduino#142
48cb809 
-Also fixes issue of not being able to rewrite the last 3/4 of the
EEPROM area
@bigdinotech bigdinotech mentioned this issue Mar 8, 2016
Closed
@bbaltz505
Copy link
Contributor Author

PR #144 fixes these issues

bbaltz505 pushed a commit that referenced this issue Mar 8, 2016
@bigdinotech
Fix Klockwork issues in CurieEEPROM #142
17eac79 
-Also fixes issue of not being able to rewrite the last 3/4 of the
EEPROM area
@kitsunami kitsunami added the bug label Mar 11, 2016
@kitsunami kitsunami added this to the Bellatrix milestone Mar 11, 2016
@bbaltz505
Copy link
Contributor Author

Latest KW scan of corelibs shows that the EEPROM issues were fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbaltz505 bbaltz505

Labels
bug
Projects
None yet
Milestone
Bellatrix
Development

No branches or pull requests
2 participants
@bbaltz505 @kitsunami