Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make WiFiClientSSL class available #647

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Make WiFiClientSSL class available #647

merged 1 commit into from
Nov 28, 2023

Conversation

karlsoderby
Copy link
Contributor

WiFiSSLClient was missing in WiFi.h, so examples using SSL fails to compile.

The SSL example was tested with the GIGA R1 WiFi board successfully.

@karlsoderby
Make SSL class available
410311f 
WiFiSSLClient was missing in the WiFi.h file, so examples using SSL fails to compile.
sebromero
sebromero approved these changes Apr 6, 2023
View reviewed changes
Copy link
Collaborator

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebromero
Copy link
Collaborator

@karlsoderby Where is the example sketch that you're referring to?

@facchinm
Copy link
Member

The issue with this commit is that it brings in ~200KB for every sketch that doesn't want to use SSL.
@sebromero it is targeting boards with 2MB of flash it may or may not be a problem, but the choice at that time was to leave it out.
Maybe adding an example would work?

facchinm
facchinm requested changes Apr 26, 2023
View reviewed changes
Copy link
Member

@facchinm facchinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take into account the flash occupation increase

@sebromero
Copy link
Collaborator

@karlsoderby Can you please point me to the examples that were not compiling?

@manchoz
Copy link
Contributor

manchoz commented Aug 9, 2023

Hi,
Can't we just include WiFiSSLClient.h header in the SSL/TLS examples?

@facchinm facchinm merged commit b2b3f39 into arduino:main Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facchinm facchinm facchinm requested changes

@sebromero sebromero sebromero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karlsoderby @sebromero @facchinm @manchoz