[Camera] Fix a synchronization bug in example #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a synchronization bug. Return if there's no timeout OR if there's no sync byte received. The previous version needed both to be true at the same time to return without sending a frame, which meant that a frame was sent if there was a timeout even if no sync byte had been received. That, in turn, caused random problems for the Processing sketch on the other end.
The timeout functionality has changed, and it needs to be explained. Timeouts because of lost sync bytes should be done on the opposite end if needed. Otherwise, the two sides get out of sync every now and then.
|
The new functionality uses the timeouts to set the (constant) frame rate. If timeouts are needed for lost sync bytes, they should be implemented on the other end to keep the synchronization robust. |
facchinm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a synchronization bug. Return if there's no timeout OR if there's no sync byte received. The previous version needed both to be true at the same time to return without sending a frame, which meant that a frame was sent if there was a timeout even if no sync byte had been received. That, in turn, caused random problems for the Processing sketch on the other end.