[AE-2] Add zoom, flip, and mirror functionality for GC2145 #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the functions zoomTo(), zoomToCenter(), setVerticalFlip(), setHorizontalMirror(), getResolutionWidth(), and getResolutionHeight() to the Camera library. The old setResolution() function is changed into the new private function setResolutionWithZoom(), which is called by the new version of setResolution(), as well as by the zoomTo() and zoomToCenter() functions. These changes required some changes in the abstract class ImageSensor, which, in turn, required further changes in the camera drivers. The only camera driver that fully supports the new functionality is GC2145, and the others return -1 on all calls. The function signature for setResolution() is changed, and two new functions are added: setVerticalFlip() and setHorizontalMirror().
The parameter names are changed from _mode to _enable.
Adds back the setResolution() function to the camera drivers by calling setResolutionWithZoom() with default parameters.
sebromero
force-pushed
the
zoom-flip-mirror
branch
from
e3745de
to
df134fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the functions
zoomTo(),zoomToCenter(),setVerticalFlip(),setHorizontalMirror(),getResolutionWidth(), andgetResolutionHeight()to the Camera library. The oldsetResolution()function is changed into the new private functionsetResolutionWithZoom(), which is called by the new version ofsetResolution(), as well as by thezoomTo()andzoomToCenter()functions.These changes required some changes in the abstract class ImageSensor, which, in turn, required further changes in the camera drivers. The only camera driver that fully supports the new functionality is GC2145, and the others return -1 on all calls. The function signature for setResolution() is changed, and two new functions are added:
setVerticalFlip()andsetHorizontalMirror().