Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SocketWrapper: avoid Stream setTimeout shadowing #769

Merged
merged 1 commit into from
Jan 9, 2024
Merged

SocketWrapper: avoid Stream setTimeout shadowing #769

merged 1 commit into from
Jan 9, 2024

Conversation

pennam
Copy link
Contributor

@pennam pennam commented Nov 22, 2023

Shoould fix #728

@JAndrassy
Copy link
Contributor

JAndrassy commented Nov 22, 2023 •
edited
Loading

it is not a connection timeout as setConnectionTimeout should do!
it is timeout on other operations, not on connect.
I recommend the name setSocketTimeout.

facchinm
facchinm requested changes Dec 4, 2023
View reviewed changes
libraries/SocketWrapper/src/MbedClient.h Outdated Show resolved Hide resolved
@pennam pennam requested a review from facchinm January 5, 2024 08:59
@facchinm facchinm merged commit fb002d4 into arduino:main Jan 9, 2024
11 checks passed
@JAndrassy JAndrassy mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facchinm facchinm Awaiting requested review from facchinm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SocketWrapper library: MbedClient.setTimeout shadows Stream.setTimeout
3 participants
@pennam @JAndrassy @facchinm