Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ethernet.h remove unimplemented methods #783

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Ethernet.h remove unimplemented methods #783

merged 1 commit into from
Dec 4, 2023

Conversation

JAndrassy
Copy link
Contributor

  • socketAddressFromIpAddress is the base class
  • setHostname causes linker error. implementation is not possible

@JAndrassy
Ethernet.h remove unimplemented methods
65617a9 
socketAddressFromIpAddress in implemented in the base class
setHostname causes linker error. implementation is not possible
@facchinm
Copy link
Member

facchinm commented Dec 4, 2023

Thanks for the contribution, they were stray functions from the very old initial implementation. Merging!

@facchinm facchinm merged commit 98b9ea5 into arduino:main Dec 4, 2023
11 checks passed
@JAndrassy JAndrassy deleted the ethernet_remove_unimplemented_methods branch December 4, 2023 14:41
@JAndrassy
Copy link
Contributor Author

JAndrassy commented Dec 5, 2023 •
edited
Loading

@facchinm Martino, to be honest, the networking libraries of this core look unfinished. There are many loose ends. I will add more PR, but without working client copying it is not even possible to test MbedServer.
And I still don't have hardware (or software in form of an EMAC driver for a cheap WiFi) to test the WiFi library, but in code I see that there will be problems with static IP configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JAndrassy @facchinm