Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NICLA VISION TLS skip server certificate date check #859

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

pennam
Copy link
Contributor

@pennam pennam commented Apr 4, 2024

This check was enabled only for NICLA VISION, and connect was failing because system time is not automatically configured. On other variants date checks are not enabled because MBEDTLS_HAVE_TIME_DATE is not defined.

  This will also avoid TLS connection to be closed because the certificate validity starts in the future
  They are already defined in target.json file and causing redefinition warnings
@pennam
Copy link
Contributor Author

pennam commented Apr 4, 2024

WiFiSSLClient 💚
ArduinoCloud 💚

@pennam pennam merged commit 79d9a8d into arduino:main Apr 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant