Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arduino_H7_Video library: Fix rotation bug in LVGL v9.2.0 #953

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Arduino_H7_Video library: Fix rotation bug in LVGL v9.2.0 #953

merged 1 commit into from
Sep 18, 2024

Conversation

leonardocavagnis
Copy link
Member

Fix #952

facchinm
facchinm requested changes Sep 17, 2024
View reviewed changes
Copy link
Member

@facchinm facchinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather force rotation = LV_DISPLAY_ROTATION_90 for LVGL_VERSION_MINOR < 2, on line 245, how does it sound?

@leonardocavagnis
Copy link
Member Author

I would rather force rotation = LV_DISPLAY_ROTATION_90 for LVGL_VERSION_MINOR < 2, on line 245, how does it sound?

Sounds good! thanks!

@leonardocavagnis leonardocavagnis merged commit 6b697fe into arduino:main Sep 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facchinm facchinm facchinm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LVGL v9.2.0 not compatible with Arduino_H7_Video library
2 participants
@leonardocavagnis @facchinm