Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No include guards in Arduino_LED_Matrix.h #228

Closed
yuriko0505 opened this issue Dec 30, 2023 · 1 comment · Fixed by #231
Closed

No include guards in Arduino_LED_Matrix.h #228

yuriko0505 opened this issue Dec 30, 2023 · 1 comment · Fixed by #231
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@yuriko0505
Copy link

yuriko0505 commented Dec 30, 2023 •
edited by per1234
Loading

https://github.com/arduino/ArduinoCore-renesas/blob/main/libraries/Arduino_LED_Matrix/src/Arduino_LED_Matrix.h

This header file does not contain include guards, so multiple includes will result in redefinition errors.
@yuriko0505

This comment was marked as duplicate.

Sign in to view
@yuriko0505 yuriko0505 changed the title LED Matrix LED Matrix: no include guards Dec 30, 2023
@per1234 per1234 changed the title LED Matrix: no include guards No include guards in Arduino_LED_Matrix.h Dec 30, 2023
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Dec 30, 2023
aentinger added a commit that referenced this issue Jan 8, 2024
@aentinger
Prevent multiple inclusion by adding include guards.
3a35927 
This fixes #228.
@aentinger aentinger mentioned this issue Jan 8, 2024
Merged
aentinger added a commit that referenced this issue Jan 8, 2024
@aentinger
Prevent multiple inclusion by adding include guards. (#231)
9ae3d9b 
This fixes #228.
@per1234 per1234 added the conclusion: resolved Issue was resolved label Jan 8, 2024
aentinger added a commit to JAndrassy/ArduinoCore-renesas that referenced this issue Jan 9, 2024
@aentinger
Prevent multiple inclusion by adding include guards. (arduino#231)
0c2cc1c 
This fixes arduino#228.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent multiple inclusion by adding include guards. arduino/ArduinoCore-renesas
2 participants
@per1234 @yuriko0505