Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiFiS3 WiFiServer operator bool #140

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

JAndrassy
Copy link
Contributor

@JAndrassy JAndrassy commented Sep 20, 2023

Server implementation in the Ethernet library for W5x00 has operator bool.

WiFiServer in esp8266 and esp32 Arduino WiFi library has bool operator.

@Fashion-Corp
Copy link

Fashion-Corp commented Sep 20, 2023 via email

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Sep 20, 2023
@Fashion-Corp
Copy link

Fashion-Corp commented Sep 21, 2023 via email

@Fashion-Corp
Copy link

Fashion-Corp commented Sep 21, 2023 via email

@per1234
Copy link
Collaborator

per1234 commented Sep 21, 2023

Hi @Fashion-Corp. Thanks for your interest in contributing to the Arduino project.

This may be the wrong place, and if so, please guide me to the right
place...

I think so. We expect the pull request and issue threads to be very tightly focused on the given specific subject. If the discussion in these threads increases in scope beyond what is directly related to that subject, or when the discussion becomes unstructured or rambling, it greatly increases the burden on the reviewers.

The appropriate communication channel to used for broadly scoped discussions related to the development of official Arduino projects such as you have initiated is the Arduino developers mailing list:

https://groups.google.com/a/arduino.cc/forum/#!forum/developers

For less structured discussion of any subject related to Arduino, or when you want to include the user community in the conversation, the appropriate communication channel is Arduino Forum:

https://forum.arduino.cc/

We look forward to talking with you more on these subjects over there.

@Fashion-Corp
Copy link

Fashion-Corp commented Sep 21, 2023 via email

@JAndrassy
Copy link
Contributor Author

@arduino arduino deleted a comment from github-actions bot Dec 5, 2023
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM 👍

@aentinger aentinger merged commit 7061327 into arduino:main Dec 13, 2023
@JAndrassy JAndrassy deleted the wifis3_server_bool branch December 13, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants