unor4: fix incorrect BSP_CLOCK_CFG_SUBCLOCK_POPULATED defines #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
type: imperfection
|
And that requires no FSP library recompile? What code in the Arduino core listens to this macro? |
|
Not able to find that. But it seems its linked to libfsp.a file |
The function is not being called by default since the pins are unused on both Minima and WiFi. A third party, however, can just call it inside initVariant() to enable the pins
facchinm
force-pushed
the
subclock_unor4
branch
from
3d6cc91 to
6546df0
Compare
|
@maxgerhardt you are right, I missed some steps... I provided a new patch that doesn't involve changing libfsp, tested to work fine on UNO R4 WiFi (should work on Minima too of course). The idea is that the function should only be called by 3rd party cores that need the pins (if they don't want to recompile libfsp) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #160
Special thanks to @simooon442 for spotting the issue