Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiFiS3/C3 - add legacy wl_enc_type constants aliases #175

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

JAndrassy
Copy link
Contributor

@JAndrassy JAndrassy commented Nov 6, 2023

previous WiFi libraries used the encryption type names ENC_TYPE_TKIP and ENC_TYPE_CCMP, which are based on the name of the encryption algorithm TKIP for WPA and CCMP for WPA2.

In WiFiS3 and WiFiC3 library constants with the well known marketing names WPA and WPA2 are used for encryption type constants.

this PR adds the legacy constants ENC_TYPE_TKIP and ENC_TYPE_CCMP as aliases.

EDIT: for WiFiC3 too

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Nov 6, 2023
@JAndrassy JAndrassy force-pushed the wifis3_enctype_legacy branch from b9abafd to 0c9c5db Compare November 6, 2023 13:07
@JAndrassy JAndrassy changed the title WiFiS3 - add legacy wl_enc_type constants aliases WiFiS3/C3 - add legacy wl_enc_type constants aliases Nov 6, 2023
@arduino arduino deleted a comment from github-actions bot Dec 5, 2023
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Makes sense.

@aentinger aentinger merged commit a9fc7ea into arduino:main Dec 14, 2023
6 checks passed
@JAndrassy JAndrassy deleted the wifis3_enctype_legacy branch December 14, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants