CNetIf - added config method to apply new static IP settings for WiFi and Ethernet #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAndrassy
force-pushed
the
cnetif_config
branch
from
0b6b113 to
68ebda1
Compare
|
I can test Ethernet now in Renesas Core so I added to this PR a fix for Ethernet which uses the same new config method. |
JAndrassy
changed the title
JAndrassy
changed the title
JAndrassy
force-pushed
the
cnetif_config
branch
from
68ebda1 to
7660c9c
Compare
in CWifi::_config netif_set_address call was missing. in Ethernet::begin static IP was not applied if invoked second time now the new CNetIf.config does the static IP change for both.
JAndrassy
force-pushed
the
cnetif_config
branch
from
7660c9c to
86b8b09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not possible to reconnect to network with a different static IP. IP settings worked only for first invocation of
begin(applied in CLwipIf::get).in CWifi::_config
netif_set_addresscall was missing.in Ethernet::begin static IP was not applied if
niwas already initialized.Now new CNetIf.config does the static IP change for both.
discovered and tested with WiFiTest and LegacyEthernetTest