New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESPHost library - protobuf-c.c as source and not as precompiled #213

Merged

aentinger merged 1 commit into arduino:main from JAndrassy:esphost_protobufc_as_source

Dec 20, 2023

Contributor

JAndrassy commented Dec 18, 2023

there is no good reason to have protobuf-c.c precompiled. it compiles fast.
it was the only .o in libprotobufc.a


          ESPHost library - protobuf-c.c as source and not as precompiled

5ca0448

JAndrassy mentioned this pull request

Do you have a shell script to build protobuf-c.a for the ESPHost library? #212

Closed

aentinger approved these changes

View reviewed changes

Contributor

aentinger left a comment

LGTM 👍 You're right, there's barely a speed trade off, also now git submodule'd protobuf version matches the one compiled into your sketch.

aentinger merged commit e13fdba into arduino:main

6 checks passed

JAndrassy deleted the esphost_protobufc_as_source branch

December 20, 2023 08:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet