Add ArduinoCore-API integration #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giulcioffi
force-pushed
the
namespaced_api
branch
from
05db380
to
d462862
Compare
giulcioffi
changed the title
|
Tested successfully with Arduino IoT Cloud for
Tested successfully in another way:
Not tested for:
|
aentinger
force-pushed
the
namespaced_api
branch
from
ca7b32d
to
f25e3da
Compare
The new class PluggableUSBModule in ArduinoCore-API does not implement the fuction void handleEndpoint(int ep) which was implemented in the previous version of the same class. This function now needs to be called as proper of SerialUSB and not of PluggableUSB().
…IMode enum values defined in HardwareSPI.h
…is different from the ones provided via global constant 'DEFAULT_SPI_SETTINGS' because otherwise SPI won't be configured within the 'config' method called within 'begin'
giulcioffi
force-pushed
the
namespaced_api
branch
from
01fd619
to
0fa5cae
Compare
This was referenced Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed modifications to ArduinoCore-samd would allow the integration with ArduinoCore-API core.
Related CI workflows are proposed in #567 .