Optimized 1200-bps touch and upload port detection. Fixed some rare upload-fail corner cases. #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
force-pushed
the
experimental-wait-plus-touch
branch
from
ab4bb63
to
a262ded
Compare
It should be an equivalent change, but it's better when reading code.
rsora
approved these changes
Apr 22, 2021
There was a problem hiding this comment.
Tests done successfully on:
linux with hub
- arduino:avr:uno
- arduino:avr:mega
- arduino:avr:leonardo
- arduino:avr:leonardoeth
- arduino:megaavr:nona4809
- arduino:mbed:nano33ble
- arduino:mbed:nanorp2040connect
- arduino:megaavr:uno2018
- arduino:samd:mkrwifi1010
- arduino:samd:nano_33_iot
- arduino:samd:arduino_zero_native
- arduino:samd:arduino_zero_edbg
- arduino:samd:mkrzero
- arduino:samd:mkr1000
- arduino:sam:arduino_due_x_dbg
- arduino:sam:arduino_due_x
windows with hub
- arduino:samd:mkrzero
- arduino:sam:arduino_due_x_dbg
- arduino:samd:mkr1000
- arduino:megaavr:uno2018
- arduino:avr:leonardoeth
- arduino:megaavr:nona4809
- arduino:mbed:nanorp2040connect
- arduino:mbed:nano33ble
- arduino:samd:arduino_zero_edbg
- arduino:avr:mega
- arduino:samd:nano_33_iot
- arduino:mbed:envie_m7
Mac OS 11.2.3 Big Sur - Intel
Tested with 2 USB-C to multiple USB-A, unpowered
Anker
Satechi
- arduino:samd:arduino_zero_native
- arduino:samd:arduino_zero_edbg
- arduino:mbed:envie_m7
- arduino:sam:arduino_due_x
- arduino:sam:arduino_due_x_edbg
- arduino:megaavr:nona4809
- arduino:mbed:nanorp2040connect
- arduino:mbed:nano33ble
- arduino:samd:mkrwifi1010
- arduino:samd:nano_33_iot
- arduino:samd:mkrzero
- arduino:samd:mkr1000
- arduino:samd:mkrgsm1400
- arduino:avr:mega
- arduino:megaavr:uno2018
- arduino:avr:leonardo
- esp32:esp32:esp32 (M5 Stack Core 2)
cmaglie
changed the title
silvanocerza
pushed a commit
that referenced
this pull request
May 10, 2021
* Refactored upload output and debug info and removed unused functions * Skip serial port touch if the port is not connected * Perform touch only if required * Slightly change test to set serial port properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @ubidefeo