-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[breaking] Refactor initialization steps #1274
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
added
type: enhancement
Proposed improvement
status: in progress
Work is in progress on this
topic: gRPC
labels
Apr 23, 2021
per1234
previously requested changes
Apr 27, 2021
cmaglie
reviewed
Apr 27, 2021
silvanocerza
force-pushed
the
scerza/init-refactoring
branch
from
May 7, 2021 09:03
849ba03
to
9ef3eae
Compare
Rebased after #1278 merge. |
silvanocerza
force-pushed
the
scerza/init-refactoring
branch
from
May 11, 2021 08:02
9ef3eae
to
95b2143
Compare
silvanocerza
force-pushed
the
scerza/init-refactoring
branch
2 times, most recently
from
June 7, 2021 13:38
9a2178c
to
12ee0a8
Compare
silvanocerza
force-pushed
the
scerza/init-refactoring
branch
from
June 15, 2021 14:29
f7fc5f5
to
1b057e4
Compare
cmaglie
approved these changes
Jun 15, 2021
Co-authored-by: per1234 <accounts@perglass.com>
silvanocerza
force-pushed
the
scerza/init-refactoring
branch
from
June 16, 2021 14:46
1b057e4
to
d84d4d9
Compare
silvanocerza
force-pushed
the
scerza/init-refactoring
branch
from
June 16, 2021 14:50
d84d4d9
to
bee0970
Compare
per1234
added
topic: code
Related to content of the project itself
and removed
status: in progress
Work is in progress on this
labels
May 4, 2022
3 tasks
This was referenced Jul 5, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)A big refactoring of the initialization steps run by the CLI both when run "one shot" or in daemon mode.
Currently the gRPC
Init
function that creates and initializes a newCoreInstance
to handle platforms and libraries that are both installed and installable returns an error and fail completely if even just one installed platform or library fails to load for any reason.This issue breaks completely the CLI or any gRPC consumer when the initialization step fails because no
CoreInstance
is created, thus preventing any other further operation.The
Init
gRPC function has now been split into two separate functions,Create
to create a newCoreInstance
and folders necessary to correctly execute the CLI, andInit
that loads indexes, platforms and libraries.The
Create
function will only fail if the creation of the necessary folders will fail, in any other case a validCoreInstance
is returned.The
Init
function has been greatly improved, now failure to load a single platform or library doesn't completely stop the loading, but a message is sent to the client to notify the failure, the client will decide how to handle the error.The CLI will print an error to the user whenever a platform or library fails to load but execution won't stop, it will only fail if the platform or library is needed to run successfully the command.
The
Rescan
gRPC function has been removed completely in favour ofInit
.UpdateIndex
andUpdateLibrariesIndex
gRPC functions now don't implicitly reload the indexes, it has to be done explicitly with theInit
function.titled accordingly?
Yes. Further information to handle the breaking change can be found in the
UPGRADING.md
file.None.
See how to contribute