Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded builtin tools #1537

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Removes hardcoded builtin package and its tools.

  • What is the current behavior?

Certain tools like ctags, serial-discovery and mdns-discovery belong to the builtin package, that package doesn't exist in the Arduino package_index.json but is hardcoded in the arduino-cli.

Whenever we need to update one of these tools we must create a new release of the Arduino CLI, that's annoying for everyone.

  • What is the new behavior?

builtin package is not hardcoded anymore, the Arduino CLI will assume the package is always present and install all its tools latest releases whenever an internal instance is initialized.

The builtin package will be added in the Arduino package_index.json.

Nope.

  • Other information:

Before merging this we'll have to add the builtin package in the Arduino package_index.json.


See how to contribute

@silvanocerza silvanocerza added type: enhancement Proposed improvement topic: code Related to content of the project itself topic: CLI Related to the command line interface topic: gRPC Related to the gRPC interface labels Nov 4, 2021
@silvanocerza silvanocerza requested a review from a team November 4, 2021 16:44
@silvanocerza silvanocerza self-assigned this Nov 4, 2021
@silvanocerza silvanocerza marked this pull request as ready for review November 4, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: CLI Related to the command line interface topic: code Related to content of the project itself topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants