-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved library search #1896
Improved library search #1896
Conversation
99c87b2
to
d4a03de
Compare
Codecov ReportBase: 36.58% // Head: 36.69% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1896 +/- ##
==========================================
+ Coverage 36.58% 36.69% +0.10%
==========================================
Files 231 231
Lines 19696 19719 +23
==========================================
+ Hits 7206 7235 +29
+ Misses 11659 11654 -5
+ Partials 831 830 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
@cmaglie, are you planning to update this PR with the |
Not in this PR, I'm working on other tasks, let's start with libraries which is the most common scenario, I will open another PR for the platform search. |
I have downloaded the CLI for macOS and manually compared dozens of search results with the Library manager from IDE 1.x. It's working great. Excellent job. |
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)Applied some changes to extend the matching libraries found by a query:
author
andprovidedIncludes
.aaa bbb
will match even ifaaa
andbbb
are not found together (as a single stirngaaa bbb
):
) are translated into spaces before splitting the query into words.See:
core/lib search results must be the same as from the IDE 1.x #1895
Add
author
field to library search scope #1894Add
providesIncludes
field to library search scope #1893All the above issues are fixed.
titled accordingly?
No
Fix core/lib search results must be the same as from the IDE 1.x #1895, Add
author
field to library search scope #1894, AddprovidesIncludes
field to library search scope #1893