Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sketch archive overrides using overwrite flag #1994

Merged

Conversation

MatteoPologruto
Copy link
Contributor

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Code imperfection fix

What is the current behavior?

It is not possibile to override existing archives with sketch archive.

What is the new behavior?

It is possibile to override existing archives using the flag -f | --overwrite.

Does this PR introduce a breaking change, and is titled accordingly?

No

@MatteoPologruto MatteoPologruto added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Nov 29, 2022
@MatteoPologruto MatteoPologruto self-assigned this Nov 29, 2022
@MatteoPologruto MatteoPologruto linked an issue Nov 29, 2022 that may be closed by this pull request
@MatteoPologruto MatteoPologruto merged commit 76ddec8 into arduino:master Nov 30, 2022
@MatteoPologruto MatteoPologruto deleted the sketch-archive-overwrite branch November 30, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gRPC] ArchiveSketchReq cannot override existing archives
2 participants