Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .xz and .zst archive format #2012

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Dec 15, 2022

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Add support for .xz and .zst archive format.

What is the current behavior?

.xz and .zst are not supported.

What is the new behavior?

.xz and .zst are supported.

Does this PR introduce a breaking change, and is titled accordingly?

No

@cmaglie cmaglie changed the title Upgraded extract to v3.1.0 Add support for .xz and .zst archive format Dec 15, 2022
@cmaglie cmaglie requested review from umbynos and per1234 December 15, 2022 14:54
@cmaglie cmaglie self-assigned this Dec 15, 2022
@cmaglie cmaglie added type: enhancement Proposed improvement priority: low Resolution is a low priority topic: code Related to content of the project itself criticality: low Of low impact labels Dec 15, 2022
@cmaglie cmaglie added this to the Arduino CLI 0.30.0 milestone Dec 15, 2022
@cmaglie cmaglie linked an issue Dec 15, 2022 that may be closed by this pull request
3 tasks
@cmaglie cmaglie force-pushed the add_archive_formats branch 2 times, most recently from b83a378 to 37a7645 Compare December 15, 2022 16:02
@cmaglie cmaglie force-pushed the add_archive_formats branch from 37a7645 to d972c21 Compare January 12, 2023 15:44
@cmaglie cmaglie force-pushed the add_archive_formats branch from d972c21 to f63ce34 Compare January 12, 2023 15:51
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 36.42% // Head: 36.49% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (f63ce34) compared to base (34762a6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2012      +/-   ##
==========================================
+ Coverage   36.42%   36.49%   +0.07%     
==========================================
  Files         228      228              
  Lines       19316    19316              
==========================================
+ Hits         7035     7050      +15     
+ Misses      11446    11435      -11     
+ Partials      835      831       -4     
Flag Coverage Δ
unit 36.49% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commands/lib/search.go 92.10% <0.00%> (+3.94%) ⬆️
arduino/monitor/monitor.go 47.36% <0.00%> (+6.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cmaglie cmaglie merged commit a735ddf into arduino:master Jan 12, 2023
@cmaglie cmaglie deleted the add_archive_formats branch January 12, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
criticality: low Of low impact priority: low Resolution is a low priority topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow packages and tools to use .tar.xz format
2 participants