Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to golang 1.19 #2026

Merged
merged 7 commits into from
Jan 5, 2023
Merged

chore: update to golang 1.19 #2026

merged 7 commits into from
Jan 5, 2023

Conversation

Bikappa
Copy link
Contributor

@Bikappa Bikappa commented Jan 4, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

It updates the golang language version used in the source files. The version is bumped from go 1.17 to go 1.19.
The change will provide the latest security patches and bug fixes in the standard library and it will allow developers to write code with modern syntax.
In this regard the main language feature brought in are generics, that enable writing of simpler and more concise interfaces in addition to the possibility to use such interfaces from third party modules.
See golang release notes for more details.

It also update go.sum files after running go mod tidy

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Not on the interface behaviours, but it's worth mentioning that go 1.19 is now required for compilation.

Other information

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 36.45% // Head: 36.43% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (7622231) compared to base (38a0dfd).
Patch has no changes to coverable lines.

❗ Current head 7622231 differs from pull request most recent head e52fbd9. Consider uploading reports for the commit e52fbd9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2026      +/-   ##
==========================================
- Coverage   36.45%   36.43%   -0.02%     
==========================================
  Files         228      228              
  Lines       19316    19316              
==========================================
- Hits         7041     7038       -3     
- Misses      11442    11444       +2     
- Partials      833      834       +1     
Flag Coverage Δ
unit 36.43% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
arduino/cores/packageindex/index.go 86.78% <ø> (ø)
arduino/security/signatures.go 75.86% <ø> (ø)
commands/daemon/settings.go 90.27% <ø> (ø)
i18n/convert.go 80.00% <ø> (ø)
commands/lib/search.go 88.15% <0.00%> (-3.95%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

i18n/convert.go Show resolved Hide resolved
@Bikappa Bikappa force-pushed the chore/go-1.19 branch 4 times, most recently from 28edac6 to 94256b7 Compare January 4, 2023 17:20
@Bikappa Bikappa marked this pull request as ready for review January 5, 2023 11:50
@Bikappa Bikappa assigned Bikappa and unassigned Bikappa Jan 5, 2023
.github/workflows/i18n-weekly-pull.yaml Outdated Show resolved Hide resolved
DistTasks.yml Outdated Show resolved Hide resolved
@Bikappa Bikappa merged commit c0d4e44 into master Jan 5, 2023
@Bikappa Bikappa deleted the chore/go-1.19 branch January 5, 2023 13:39
@cmaglie cmaglie added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants