Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed regression in compile_commands.json generation #2427

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Nov 15, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fixed a regression in compile_commands.json generation.
This feature is mainly used in arduino-language-server.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

Fix #2401

@cmaglie cmaglie added type: imperfection Perceived defect in any part of project topic: build-process Related to the sketch build process labels Nov 15, 2023
@cmaglie cmaglie self-assigned this Nov 15, 2023
@cmaglie cmaglie added this to the Arduino CLI v0.35.0 milestone Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.31%. Comparing base (6c86fa2) to head (f42483d).
Report is 214 commits behind head on master.

Files with missing lines Patch % Lines
arduino/builder/internal/detector/detector.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2427      +/-   ##
==========================================
+ Coverage   67.27%   67.31%   +0.03%     
==========================================
  Files         210      210              
  Lines       20523    20522       -1     
==========================================
+ Hits        13807    13814       +7     
+ Misses       5578     5568      -10     
- Partials     1138     1140       +2     
Flag Coverage Δ
unit 67.31% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯
image

@cmaglie cmaglie merged commit bd2d886 into arduino:master Nov 15, 2023
98 checks passed
@cmaglie cmaglie deleted the fix-compile-commands-for-ls branch November 15, 2023 15:00
cmaglie added a commit that referenced this pull request Nov 15, 2023
* Fixed regression in compile_commands.json generation

* Added integration tests
@per1234 per1234 added the topic: code Related to content of the project itself label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: build-process Related to the sketch build process topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arduino Language Server produces a lot of compiler errors when used with Arduino CLI 0.35.0-rc.1
3 participants