Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] Removed Profile protoc message in favor of SketchProfile #2507

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jan 18, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Removes the Profile protoc message from the gRPC API that is a duplicate of SketchProfile.

What is the current behavior?

No changes

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Yes

Other information

@cmaglie cmaglie added type: enhancement Proposed improvement topic: gRPC Related to the gRPC interface labels Jan 18, 2024
@cmaglie cmaglie added this to the Arduino CLI v1.0.0 milestone Jan 18, 2024
@cmaglie cmaglie self-assigned this Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (96b411f) 68.90% compared to head (96d20a8) 68.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2507   +/-   ##
=======================================
  Coverage   68.90%   68.91%           
=======================================
  Files         204      204           
  Lines       20452    20448    -4     
=======================================
- Hits        14093    14092    -1     
+ Misses       5209     5207    -2     
+ Partials     1150     1149    -1     
Flag Coverage Δ
unit 68.91% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️

@cmaglie cmaglie merged commit 47645e9 into arduino:master Jan 18, 2024
104 checks passed
@cmaglie cmaglie deleted the fix_2 branch January 18, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants