Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] gRPC: improved CompileRequest.export_binaries field definition #2570

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Mar 25, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

The optional gRPC field export_binaries now leverage the optional clause in latest version of protobuf 3 protocol.

What is the current behavior?

No change

What is the new behavior?

No change

Does this PR introduce a breaking change, and is titled accordingly?

Yes

Other information

related to #2565

@cmaglie cmaglie added type: enhancement Proposed improvement topic: gRPC Related to the gRPC interface labels Mar 25, 2024
@cmaglie cmaglie added this to the Arduino CLI v1.0.0 milestone Mar 25, 2024
@cmaglie cmaglie self-assigned this Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 69.56%. Comparing base (6faca0f) to head (fecb334).
Report is 1 commits behind head on master.

❗ Current head fecb334 differs from pull request most recent head 16e1ba6. Consider uploading reports for the commit 16e1ba6 to get more accurate results

Files Patch % Lines
commands/compile/compile.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2570      +/-   ##
==========================================
- Coverage   69.58%   69.56%   -0.02%     
==========================================
  Files         205      205              
  Lines       20267    20255      -12     
==========================================
- Hits        14102    14090      -12     
  Misses       5049     5049              
  Partials     1116     1116              
Flag Coverage Δ
unit 69.56% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit 71c55d7 into arduino:master Mar 25, 2024
103 checks passed
@cmaglie cmaglie deleted the optional_export_binaries branch March 25, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants