Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed extremely rare race condition in DiscoveryManager #2589

Merged
merged 1 commit into from
May 3, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented May 3, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fix a bug in the discovery manager.

What is the current behavior?

No change

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

@cmaglie cmaglie added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels May 3, 2024
@cmaglie cmaglie self-assigned this May 3, 2024
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.50%. Comparing base (2063b6a) to head (092178f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2589      +/-   ##
==========================================
- Coverage   69.51%   69.50%   -0.01%     
==========================================
  Files         207      207              
  Lines       20280    20285       +5     
==========================================
+ Hits        14097    14099       +2     
- Misses       5069     5071       +2     
- Partials     1114     1115       +1     
Flag Coverage Δ
unit 69.50% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit 03d8653 into arduino:master May 3, 2024
98 checks passed
@cmaglie cmaglie deleted the disc_fix branch May 3, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants