Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile: fix export when artifacts contains a folder #2788

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

alessio-perugini
Copy link
Contributor

@alessio-perugini alessio-perugini commented Dec 17, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fixes the export-dir, when it tries to copy a folder it crashes.

What is the current behavior?

The copy mechanism fails to copy the dir because it's treated as a file, and the compile exits with error code 1

What is the new behavior?

We filter out the directories and copy only exported binaries files.

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@alessio-perugini alessio-perugini self-assigned this Dec 17, 2024
@alessio-perugini alessio-perugini added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Dec 17, 2024
@alessio-perugini alessio-perugini changed the title compile: fix export artifact when contins folder compile: fix export artifact when contains a folder Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.58%. Comparing base (84fc413) to head (05f1851).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2788      +/-   ##
==========================================
+ Coverage   67.57%   67.58%   +0.01%     
==========================================
  Files         238      238              
  Lines       22362    22363       +1     
==========================================
+ Hits        15111    15115       +4     
+ Misses       6062     6060       -2     
+ Partials     1189     1188       -1     
Flag Coverage Δ
unit 67.58% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessio-perugini alessio-perugini force-pushed the fix-export-artifacts-subdir branch from fe010cb to e6c2e6b Compare December 17, 2024 15:31
@alessio-perugini alessio-perugini force-pushed the fix-export-artifacts-subdir branch 2 times, most recently from 1944f02 to 8ebca9f Compare December 17, 2024 15:53
@alessio-perugini alessio-perugini marked this pull request as ready for review December 17, 2024 15:57
@cmaglie cmaglie changed the title compile: fix export artifact when contains a folder compile: fix export when artifacts contains a folder Dec 20, 2024
@alessio-perugini alessio-perugini merged commit 0a116e7 into master Dec 20, 2024
196 checks passed
@alessio-perugini alessio-perugini deleted the fix-export-artifacts-subdir branch December 20, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants